From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joel Becker Date: Wed, 7 Sep 2011 10:57:49 -0700 Subject: [Ocfs2-devel] block64 failure In-Reply-To: <4E67A593.70302@oracle.com> References: <4E67A593.70302@oracle.com> Message-ID: <20110907175748.GA17687@noexit.corp.google.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ocfs2-devel@oss.oracle.com On Wed, Sep 07, 2011 at 10:10:43AM -0700, Sunil Mushran wrote: > All, > > So the patches added to allow mounting volumes > 16TB has a problem. > The feature check of the jbd2 superblock is being done before the > jbd2 superblock is actually read. > > It is being done after the journal_init_inode() which is incorrect. > > ocfs2_check_volume() > ocfs2_journal_init() > jbd2_journal_init_inode() > ocfs2_journal_addressable() <=== check > ... > > Currently the journal sb is first read during load_journal. Too late for us. > And journal_get_superblock() is not exported. I'm confused. jbd2_journal_check_used_features() reads the journal superblock if needed. Why does this not satisfy? Joel -- "The one important thing i have learned over the years is the difference between taking one's work seriously and taking one's self seriously. The first is imperative and the second is disastrous." -Margot Fonteyn http://www.jlbec.org/ jlbec at evilplan.org