From: Thomas Rast <trast@student.ethz.ch>
To: Jeff King <peff@peff.net>
Cc: <git@vger.kernel.org>, "John S. Urban\"" <urbanjost@comcast.net>,
Tor Arntsen <tor@spacetec.no>, knittl <knittl89@googlemail.com>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] Documentation: "on for all" configuration of notes.rewriteRef
Date: Wed, 7 Sep 2011 23:29:17 +0200 [thread overview]
Message-ID: <201109072329.18338.trast@student.ethz.ch> (raw)
In-Reply-To: <20110907212310.GH13364@sigill.intra.peff.net>
Jeff King wrote:
> On Sun, Sep 04, 2011 at 10:27:04PM +0200, Thomas Rast wrote:
>
> > Users had problems finding a working setting for notes.rewriteRef.
> > Document how to enable rewriting for all notes.
>
> Hmm. Is this a safe thing to recommend?
>
> I think the idea of storing something like generation numbers in
> git-notes is dead at this point, but it would be quite disastrous to
> have generation numbers copied to rebased commits. Ditto for something
> like a patch-id cache. Should these sorts of immutable cache notes, if
> and when they do come about, go into a separate hierarchy?
Admittedly I never considered the problem of supposedly-immutable
notes here. The whole point was to help users who had no idea that
the string put there should probably start with refs/notes/.
So maybe the patch should instead say something along the lines of, to
enable rewriting for the notes ref called foo, put refs/notes/foo --
which to a core gitter of course sounds extremely redundant.
But what about the general issue of users who *have* put refs/notes/*,
and then some software comes along that does not expect them to be
rewritten? Do we declare the software broken, or discourage from such
blanket rewriting?
--
Thomas Rast
trast@{inf,student}.ethz.ch
next prev parent reply other threads:[~2011-09-07 21:29 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-04 1:32 Lost association between TAGS and COMMITs when rebased a git(1) repository John S. Urban
2011-09-04 10:02 ` PJ Weisberg
2011-09-04 13:40 ` Michael Witten
2011-09-04 14:03 ` Michael Witten
[not found] ` <CA+sFfMcMgPDyCi6SCS=Sc4XFrug_Ee7vbmBBkmkwfwwpXg8yCg@mail.gmail.com>
2011-09-04 14:38 ` Michael Witten
2011-09-04 17:20 ` Philip Oakley
2011-09-04 18:15 ` knittl
2011-09-04 14:30 ` knittl
2011-09-04 14:43 ` Michael Witten
2011-09-04 15:39 ` Jakub Narebski
2011-09-04 18:16 ` Tor Arntsen
2011-09-04 18:43 ` Thomas Rast
2011-09-04 19:11 ` Tor Arntsen
2011-09-04 20:18 ` John S. Urban
2011-09-04 20:28 ` [PATCH] Documentation: "on for all" configuration of notes.rewriteRef Thomas Rast
2011-09-04 20:43 ` Tor Arntsen
2011-09-07 21:23 ` Jeff King
2011-09-07 21:29 ` Thomas Rast [this message]
2011-09-07 21:35 ` Jeff King
[not found] ` <CACx-yZ1Ce3x=ZSdm5iY3JqYjVGVs5uPnb12-tMJP7zWsGuMK_Q@mail.gmail.com>
2011-09-04 16:40 ` Lost association between TAGS and COMMITs when rebased a git(1) repository John S. Urban
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201109072329.18338.trast@student.ethz.ch \
--to=trast@student.ethz.ch \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=knittl89@googlemail.com \
--cc=peff@peff.net \
--cc=tor@spacetec.no \
--cc=urbanjost@comcast.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.