From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH] ASoC: omap: convert per-board modules to platform drivers Date: Thu, 8 Sep 2011 09:13:42 -0700 Message-ID: <20110908161341.GA3098@opensource.wolfsonmicro.com> References: <1315494354-17597-1-git-send-email-mans.rullgard@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from opensource2.wolfsonmicro.com (opensource.wolfsonmicro.com [80.75.67.52]) by alsa0.perex.cz (Postfix) with ESMTP id C0A9E24BAB for ; Thu, 8 Sep 2011 18:13:47 +0200 (CEST) Content-Disposition: inline In-Reply-To: <1315494354-17597-1-git-send-email-mans.rullgard@linaro.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Mans Rullgard Cc: alsa-devel@alsa-project.org, Russell King , Tony Lindgren , linux-kernel@vger.kernel.org, Takashi Iwai , linaro-dev@lists.linaro.org, linux-omap@vger.kernel.org, Liam Girdwood , linux-arm-kernel@lists.infradead.org List-Id: alsa-devel@alsa-project.org On Thu, Sep 08, 2011 at 04:05:53PM +0100, Mans Rullgard wrote: > +static struct platform_device omap_soc_audio = { > + .name = "omap-soc-audio", > + .id = -1, > +}; > + This isn't really accomplishing anything as you're using the same device name for all boards, it's essentially the same thing as soc-audio just an OMAP version of that device. Each machine driver should be a separate platform driver. From mboxrd@z Thu Jan 1 00:00:00 1970 From: broonie@opensource.wolfsonmicro.com (Mark Brown) Date: Thu, 8 Sep 2011 09:13:42 -0700 Subject: [PATCH] ASoC: omap: convert per-board modules to platform drivers In-Reply-To: <1315494354-17597-1-git-send-email-mans.rullgard@linaro.org> References: <1315494354-17597-1-git-send-email-mans.rullgard@linaro.org> Message-ID: <20110908161341.GA3098@opensource.wolfsonmicro.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Sep 08, 2011 at 04:05:53PM +0100, Mans Rullgard wrote: > +static struct platform_device omap_soc_audio = { > + .name = "omap-soc-audio", > + .id = -1, > +}; > + This isn't really accomplishing anything as you're using the same device name for all boards, it's essentially the same thing as soc-audio just an OMAP version of that device. Each machine driver should be a separate platform driver. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754837Ab1IHXWS (ORCPT ); Thu, 8 Sep 2011 19:22:18 -0400 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:49815 "EHLO opensource2.wolfsonmicro.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753892Ab1IHXWJ (ORCPT ); Thu, 8 Sep 2011 19:22:09 -0400 Date: Thu, 8 Sep 2011 09:13:42 -0700 From: Mark Brown To: Mans Rullgard Cc: linux-omap@vger.kernel.org, linaro-dev@lists.linaro.org, Tony Lindgren , Russell King , Jarkko Nikula , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: [PATCH] ASoC: omap: convert per-board modules to platform drivers Message-ID: <20110908161341.GA3098@opensource.wolfsonmicro.com> References: <1315494354-17597-1-git-send-email-mans.rullgard@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1315494354-17597-1-git-send-email-mans.rullgard@linaro.org> X-Cookie: Avoid reality at all costs. User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 08, 2011 at 04:05:53PM +0100, Mans Rullgard wrote: > +static struct platform_device omap_soc_audio = { > + .name = "omap-soc-audio", > + .id = -1, > +}; > + This isn't really accomplishing anything as you're using the same device name for all boards, it's essentially the same thing as soc-audio just an OMAP version of that device. Each machine driver should be a separate platform driver.