From: Oleg Nesterov <oleg@redhat.com>
To: Denys Vlasenko <vda.linux@googlemail.com>
Cc: Tejun Heo <tj@kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Simplify PTRACE_foo constants and PTRACE_SETOPTIONS code
Date: Thu, 8 Sep 2011 20:37:08 +0200 [thread overview]
Message-ID: <20110908183708.GA28841@redhat.com> (raw)
In-Reply-To: <CAK1hOcMmwbSuDA2g4Tt7EO6sqjq-n-URTnMbr7RszqkMcs5jEA@mail.gmail.com>
On 09/08, Denys Vlasenko wrote:
>
> On Thu, Sep 8, 2011 at 2:06 AM, Tejun Heo <tj@kernel.org> wrote:
> > And it would be great if it explains what the historical bug was and
> > what the intended behavior is.
ptrace_setoptions() always changes ->ptrace, even if it returns
-EINVAL later.
> I'd rather nuke the bug in a follow-up patch (by deleting this line).
Denys, I think it would be much better to send 1/2 which fixes this oddity.
And note that this patch is wrong, I'll comment v3.
Oleg.
prev parent reply other threads:[~2011-09-08 23:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-07 21:36 [PATCH] Simplify PTRACE_foo constants and PTRACE_SETOPTIONS code Denys Vlasenko
2011-09-08 0:06 ` Tejun Heo
2011-09-08 12:13 ` Denys Vlasenko
2011-09-08 18:37 ` Oleg Nesterov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110908183708.GA28841@redhat.com \
--to=oleg@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
--cc=vda.linux@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.