From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Frysinger Date: Thu, 8 Sep 2011 20:50:50 -0400 Subject: [U-Boot] [PATCH 3/7] Add timing information to printf's for use with bootgraph.pl In-Reply-To: <20110907211003.BE225140875D@gemini.denx.de> References: <1314829261-13996-1-git-send-email-amurray@theiet.org> <201108311847.16042.vapier@gentoo.org> <20110907211003.BE225140875D@gemini.denx.de> Message-ID: <201109082050.51313.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wednesday, September 07, 2011 17:10:03 Wolfgang Denk wrote: > Mike Frysinger wrote: > > NAK for a few reasons: > > - i dont see how this could possibly compile warning free > > - you never initialize "i", only added to it > > - you call va_start() inbetween variable decls > > Could you _please_ accustom yourself to updating the status in > patchwork to "changes requested" when sending revierw comments like > here? be nice if patchwork itself would key off a tag we could use in our e-mails and auto set the status ... -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: This is a digitally signed message part. Url : http://lists.denx.de/pipermail/u-boot/attachments/20110908/6d7f6782/attachment.pgp