From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:51027) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R1tCL-0004e9-Ch for qemu-devel@nongnu.org; Fri, 09 Sep 2011 01:00:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R1tCK-0006aO-5U for qemu-devel@nongnu.org; Fri, 09 Sep 2011 01:00:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:2701) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R1tCJ-0006aA-Uc for qemu-devel@nongnu.org; Fri, 09 Sep 2011 01:00:16 -0400 Date: Fri, 9 Sep 2011 08:01:16 +0300 From: "Michael S. Tsirkin" Message-ID: <20110909050116.GA3895@redhat.com> References: <4E689C9F.3070000@siemens.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4E689C9F.3070000@siemens.com> Subject: Re: [Qemu-devel] [PATCH] pci: Remove unused pci_reserve_capability List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: qemu-devel On Thu, Sep 08, 2011 at 12:44:47PM +0200, Jan Kiszka wrote: > eepro100 was the last user. Now pci_add_capability is powerful enough. > > Signed-off-by: Jan Kiszka Applied, thanks. > --- > hw/pci.c | 6 ------ > hw/pci.h | 2 -- > 2 files changed, 0 insertions(+), 8 deletions(-) > > diff --git a/hw/pci.c b/hw/pci.c > index 57ff7b1..63c346d 100644 > --- a/hw/pci.c > +++ b/hw/pci.c > @@ -2028,12 +2028,6 @@ void pci_del_capability(PCIDevice *pdev, uint8_t cap_id, uint8_t size) > pdev->config[PCI_STATUS] &= ~PCI_STATUS_CAP_LIST; > } > > -/* Reserve space for capability at a known offset (to call after load). */ > -void pci_reserve_capability(PCIDevice *pdev, uint8_t offset, uint8_t size) > -{ > - memset(pdev->used + offset, 0xff, size); > -} > - > uint8_t pci_find_capability(PCIDevice *pdev, uint8_t cap_id) > { > return pci_find_capability_list(pdev, cap_id, NULL); > diff --git a/hw/pci.h b/hw/pci.h > index 391217e..f2dae63 100644 > --- a/hw/pci.h > +++ b/hw/pci.h > @@ -209,8 +209,6 @@ int pci_add_capability(PCIDevice *pdev, uint8_t cap_id, > > void pci_del_capability(PCIDevice *pci_dev, uint8_t cap_id, uint8_t cap_size); > > -void pci_reserve_capability(PCIDevice *pci_dev, uint8_t offset, uint8_t size); > - > uint8_t pci_find_capability(PCIDevice *pci_dev, uint8_t cap_id); > > > -- > 1.7.3.4