From: Greg KH <gregkh@suse.de>
To: Donggeun Kim <dg77.kim@samsung.com>
Cc: linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
akpm@linux-foundation.org, jic23@cam.ac.kr,
kyungmin.park@samsung.com
Subject: Re: [PATCH v2] misc: Add driver for GP2AP002 proximity/ambient light sensor
Date: Fri, 9 Sep 2011 01:31:34 -0700 [thread overview]
Message-ID: <20110909083134.GA21835@suse.de> (raw)
In-Reply-To: <1315556546-7445-1-git-send-email-dg77.kim@samsung.com>
On Fri, Sep 09, 2011 at 05:22:26PM +0900, Donggeun Kim wrote:
> SHARP GP2AP002 is proximity and ambient light sensor.
> This patch supports it.
>
> Signed-off-by: Donggeun Kim <dg77.kim@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> Changes for v2
> - changed to expose lux
> - changed request_irq to request_threaded_irq function
> - added sysfs_notify function call
Why? You should never do that unless you _really_ know what you are
doing.
> - cleaned up code
>
> Documentation/misc-devices/gp2ap002 | 44 +++
> drivers/misc/Kconfig | 10 +
> drivers/misc/Makefile | 1 +
> drivers/misc/gp2ap002.c | 488 ++++++++++++++++++++++++++++++++
> include/linux/platform_data/gp2ap002.h | 69 +++++
Shouldn't this be an iio driver instead of some random misc driver with
an undocumented sysfs file (hint, use Documentation/ABI for documenting
stuff...) ?
greg k-h
next prev parent reply other threads:[~2011-09-09 8:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-09 8:22 [PATCH v2] misc: Add driver for GP2AP002 proximity/ambient light sensor Donggeun Kim
2011-09-09 8:31 ` Greg KH [this message]
2011-09-09 9:16 ` Jonathan Cameron
2011-09-09 16:28 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110909083134.GA21835@suse.de \
--to=gregkh@suse.de \
--cc=akpm@linux-foundation.org \
--cc=dg77.kim@samsung.com \
--cc=jic23@cam.ac.kr \
--cc=kyungmin.park@samsung.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.