From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:54846) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R1x2v-0006km-Es for qemu-devel@nongnu.org; Fri, 09 Sep 2011 05:06:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R1x2u-0002iM-Hs for qemu-devel@nongnu.org; Fri, 09 Sep 2011 05:06:49 -0400 Received: from mail-bw0-f45.google.com ([209.85.214.45]:60492) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R1x2u-0002hn-7N for qemu-devel@nongnu.org; Fri, 09 Sep 2011 05:06:48 -0400 Received: by bkbzv3 with SMTP id zv3so1499518bkb.4 for ; Fri, 09 Sep 2011 02:06:47 -0700 (PDT) From: Marek Vasut Date: Fri, 9 Sep 2011 11:06:39 +0200 References: <1315527770-22318-1-git-send-email-marek.vasut@gmail.com> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201109091106.39981.marek.vasut@gmail.com> Subject: Re: [Qemu-devel] [PATCH] ARM7TDMI: Enable ARMv4T features List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: dbaryshkov@gmail.com, qemu-devel@nongnu.org On Friday, September 09, 2011 09:52:42 AM Peter Maydell wrote: > On 9 September 2011 01:22, Marek Vasut wrote: > > Signed-off-by: Marek Vasut > > --- > > target-arm/helper.c | 1 + > > 1 files changed, 1 insertions(+), 0 deletions(-) > > > > diff --git a/target-arm/helper.c b/target-arm/helper.c > > index 58cd99f..2f3e937 100644 > > --- a/target-arm/helper.c > > +++ b/target-arm/helper.c > > @@ -53,6 +53,7 @@ static void cpu_reset_model_id(CPUARMState *env, > > uint32_t id) env->cp15.c0_cpuid = id; > > switch (id) { > > case ARM_CPUID_ARM7TDMI: > > + set_feature(env, ARM_FEATURE_V4T); > > // set_feature(env, ARM_FEATURE_ABORT_BU); > > // set_feature(env, ARM_FEATURE_NO_CP15); > > break; > > Did you mean to send this as part of a patch series or something? > Upstream qemu doesn't have any support for ARM7TDMI (and in particular > doesn't even define ARM_CPUID_ARM7TDMI), so this patch obviously > applies on top of something else... Ah damn, I just realized I have it on top of a patchset from some other person. I'll continue cleaning up the patchset, then submit the whole thing. Please ignore this one. Cheers > > -- PMM