From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 05/11] FEC: Allow selection of MII mode via CONFIG_FEC_XCV_TYPE
Date: Fri, 9 Sep 2011 11:13:32 +0200 [thread overview]
Message-ID: <201109091113.32700.marek.vasut@gmail.com> (raw)
In-Reply-To: <201109082048.47609.vapier@gentoo.org>
On Friday, September 09, 2011 02:48:46 AM Mike Frysinger wrote:
> On Thursday, September 08, 2011 16:37:16 Marek Vasut wrote:
> > --- a/drivers/net/fec_mxc.c
> > +++ b/drivers/net/fec_mxc.c
> > @@ -38,6 +38,10 @@ DECLARE_GLOBAL_DATA_PTR;
> >
> > #error "CONFIG_MII has to be defined!"
> > #endif
> >
> > +#ifndef CONFIG_FEC_XCV_TYPE
> > +#define CONFIG_FEC_XCV_TYPE MII100
> > +#endif
> > +
> >
> > #undef DEBUG
> >
> > struct nbuf {
> >
> > @@ -711,7 +715,7 @@ static int fec_probe(bd_t *bd)
> >
> > fec->eth = (struct ethernet_regs *)IMX_FEC_BASE;
> > fec->bd = bd;
> >
> > - fec->xcv_type = MII100;
> > + fec->xcv_type = CONFIG_FEC_XCV_TYPE;
>
> shouldnt this be a parameter to fec_probe() ?
> -mike
We plan to add a driver model eventually. Until then, let's not polute this more
than necessary.
next prev parent reply other threads:[~2011-09-09 9:13 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-08 20:37 [U-Boot] [PATCH 00/11] Support for both FEC interfaces on i.MX28 Marek Vasut
2011-09-08 20:37 ` [U-Boot] [PATCH 01/11] FEC: Use proper accessor to read register in debug call Marek Vasut
2011-09-08 20:37 ` [U-Boot] [PATCH 02/11] FEC: Use defined constant instead of magic number Marek Vasut
2011-09-08 20:37 ` [U-Boot] [PATCH 03/11] FEC: Kill mode select FIXME's Marek Vasut
2011-09-09 0:48 ` Mike Frysinger
2011-09-09 12:19 ` Marek Vasut
2011-09-08 20:37 ` [U-Boot] [PATCH 04/11] FEC: Add RMII mode support Marek Vasut
2011-09-08 20:37 ` [U-Boot] [PATCH 05/11] FEC: Allow selection of MII mode via CONFIG_FEC_XCV_TYPE Marek Vasut
2011-09-09 0:48 ` Mike Frysinger
2011-09-09 9:13 ` Marek Vasut [this message]
2011-09-08 20:37 ` [U-Boot] [PATCH 06/11] FEC: Abstract access to fec->eth in MII operations Marek Vasut
2011-09-08 20:37 ` [U-Boot] [PATCH 07/11] FEC: Allow multiple FECes Marek Vasut
2011-09-08 20:37 ` [U-Boot] [PATCH 08/11] FEC: Allow registering MII postconfiguration callback Marek Vasut
2011-09-08 20:37 ` [U-Boot] [PATCH 09/11] FEC: Add timeout for chip reset Marek Vasut
2011-09-08 20:37 ` [U-Boot] [PATCH 10/11] FEC: Squish "got MAC from fuse" message, make it debug() Marek Vasut
2011-09-08 20:37 ` [U-Boot] [PATCH 11/11] FEC: Move imx_get_mac_from_fuse() definition to fec_mxc.h Marek Vasut
-- strict thread matches above, loose matches on Subject: below --
2011-09-12 4:05 [U-Boot] [PATCH 00/11 V2] Support for both FEC interfaces on i.MX28 Marek Vasut
2011-09-12 4:05 ` [U-Boot] [PATCH 05/11] FEC: Allow selection of MII mode via CONFIG_FEC_XCV_TYPE Marek Vasut
2011-09-22 10:59 ` Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201109091113.32700.marek.vasut@gmail.com \
--to=marek.vasut@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.