From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933966Ab1IIXAN (ORCPT ); Fri, 9 Sep 2011 19:00:13 -0400 Received: from mail132.messagelabs.com ([216.82.242.115]:59233 "EHLO mail132.messagelabs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759098Ab1IIXAL (ORCPT ); Fri, 9 Sep 2011 19:00:11 -0400 X-Env-Sender: hartleys@visionengravers.com X-Msg-Ref: server-9.tower-132.messagelabs.com!1315609210!14840650!1 X-Originating-IP: [216.166.12.97] X-StarScan-Version: 6.3.6; banners=-,-,- X-VirusChecked: Checked From: H Hartley Sweeten To: Linux Kernel Subject: [PATCH] arch/x86/kernel/kprobes.c: quiet sprase noise about external linkage Date: Fri, 9 Sep 2011 15:59:57 -0700 User-Agent: KMail/1.9.9 CC: , , , , , , MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-ID: <201109091559.58280.hartleys@visionengravers.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The function arch_unoptimize_kprobes is already declared extern in . The actual function should not be marked as extern. This quiets the following sparse noise: warning: function 'arch_unoptimize_kprobes' with external linkage has definition Signed-off-by: H Hartley Sweeten Cc: Thomas Gleixner Cc: Ingo Molnar Cc: "H. Peter Anvin" Cc: Masami Hiramatsu Cc: Namhyung Kim Cc: Jiri Olsa --- diff --git a/arch/x86/kernel/kprobes.c b/arch/x86/kernel/kprobes.c index f1a6244..e8d5903 100644 --- a/arch/x86/kernel/kprobes.c +++ b/arch/x86/kernel/kprobes.c @@ -1483,8 +1483,8 @@ static void __kprobes setup_unoptimize_kprobe(struct text_poke_param *tprm, * Recover original instructions and breakpoints from relative jumps. * Caller must call with locking kprobe_mutex. */ -extern void arch_unoptimize_kprobes(struct list_head *oplist, - struct list_head *done_list) +void arch_unoptimize_kprobes(struct list_head *oplist, + struct list_head *done_list) { struct optimized_kprobe *op, *tmp; int c = 0;