From: Greg KH <greg@kroah.com>
To: Nitin Gupta <ngupta@vflare.org>
Cc: Jerome Marchand <jmarchan@redhat.com>,
Pekka Enberg <penberg@cs.helsinki.fi>,
Robert Jennings <rcj@linux.vnet.ibm.com>,
Linux Driver Project <devel@linuxdriverproject.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Noah Watkins <noahwatkins@gmail.com>
Subject: Re: [PATCH 3/5] zram: Make gobal variables use unique names
Date: Fri, 9 Sep 2011 17:45:41 -0700 [thread overview]
Message-ID: <20110910004541.GA27375@kroah.com> (raw)
In-Reply-To: <4E6AB0EA.9090505@vflare.org>
On Fri, Sep 09, 2011 at 08:35:54PM -0400, Nitin Gupta wrote:
> On 09/09/2011 07:10 PM, Greg KH wrote:
>
> > On Fri, Sep 09, 2011 at 07:01:02PM -0400, Nitin Gupta wrote:
> >> Global variables 'num_devices' and 'devices' are too
> >> general to be global. This patch switches the name to
> >> be "zram_devices".
> >>
> >> Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
> >> Signed-off-by: Nitin Gupta <ngupta@vflare.org>
> >
> > I've already applied this patch, right?
> >
>
>
> I just checked another (staging-next) tree which is sync'ed more
> recently and yes this patch has been applied. Since git.kernel.org
> seems to be down I couldn't see this change on my working tree.
>
> However, that previous change actually also renamed module parameter
> name 'num_devices' to 'zram_num_devices' which does not make much sense
> since the boot parameter would now be 'zram.zram_num_devices='. All
> that's needed is to rename that global variable to some less generic
> name but the boot/command line parameter name should be retained as
> 'zram.num_devices=' which is what this new patch does.
>
> So, would it possible for you to back-out that original change and apply
> this change instead. Or, should I send a new patch series that "fixes"
> that previous change?
Send a patch that "fixes" it.
thanks,
greg k-h
next prev parent reply other threads:[~2011-09-10 0:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-09 23:00 [PATCH 0/5 v3] zram: minor cleanups and features Nitin Gupta
2011-09-09 23:01 ` [PATCH 1/5] zram: Fix sparse warnings Nitin Gupta
2011-09-09 23:01 ` [PATCH 2/5] zram: Kernel config option for number of devices Nitin Gupta
2011-09-09 23:09 ` Greg KH
2011-09-10 2:15 ` Nitin Gupta
2011-09-09 23:01 ` [PATCH 3/5] zram: Make gobal variables use unique names Nitin Gupta
2011-09-09 23:10 ` Greg KH
2011-09-10 0:35 ` Nitin Gupta
2011-09-10 0:45 ` Greg KH [this message]
2011-09-09 23:01 ` [PATCH 4/5] zram: Simplify zram disk resizing interface Nitin Gupta
2011-09-09 23:11 ` Greg KH
2011-09-10 0:12 ` Nitin Gupta
2011-09-10 0:41 ` Greg KH
2011-09-09 23:01 ` [PATCH 5/5] zram: Set initial disksize to some default value Nitin Gupta
2011-09-09 23:12 ` Greg KH
2011-09-10 0:18 ` Nitin Gupta
2011-09-10 0:42 ` Greg KH
2011-09-10 14:51 ` Nitin Gupta
2011-09-10 0:50 ` Valdis.Kletnieks
2011-09-10 2:04 ` Nitin Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110910004541.GA27375@kroah.com \
--to=greg@kroah.com \
--cc=devel@linuxdriverproject.org \
--cc=jmarchan@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ngupta@vflare.org \
--cc=noahwatkins@gmail.com \
--cc=penberg@cs.helsinki.fi \
--cc=rcj@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.