From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH v2] ASoC: omap: convert per-board modules to platform drivers Date: Sat, 10 Sep 2011 22:37:15 +0200 Message-ID: <201109102237.15193.arnd@arndb.de> References: <3110288.bQbb0H2ME1@wuerfel> <20110909193010.GA2993@opensource.wolfsonmicro.com> <20110909205645.GA16355@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from moutng.kundenserver.de (moutng.kundenserver.de [212.227.126.186]) by alsa0.perex.cz (Postfix) with ESMTP id B4F372464C for ; Sat, 10 Sep 2011 22:37:23 +0200 (CEST) In-Reply-To: <20110909205645.GA16355@n2100.arm.linux.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Russell King - ARM Linux Cc: alsa-devel@alsa-project.org, Jassi Brar , linaro-dev@lists.linaro.org, Tony Lindgren , Mark Brown , linux-kernel@vger.kernel.org, Mans Rullgard , Grant Likely , Takashi Iwai , linux-omap@vger.kernel.org, Liam Girdwood , linux-arm-kernel@lists.infradead.org List-Id: alsa-devel@alsa-project.org On Friday 09 September 2011, Russell King - ARM Linux wrote: > That's just twisted and utterly insane - adding more code for precisely > zero benefit what so ever. Think about it - the device tree is already > creating platform devices for entries in the device tree file. What's > the point of having this special ASoC code look up the platform compatible > property in a table of strings to find a different string to manually > create a device with. Why not just add the bloody device to the DT > file in the first place? That's partly what DT is there for - to create > platform specific struct devices. Exactly. No driver or (worse) user program should ever need to look at the top-level compatible property. When you want information about a localized part of the system (e.g. the ASoC components), you should look up the information for that component. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Sat, 10 Sep 2011 22:37:15 +0200 Subject: [PATCH v2] ASoC: omap: convert per-board modules to platform drivers In-Reply-To: <20110909205645.GA16355@n2100.arm.linux.org.uk> References: <3110288.bQbb0H2ME1@wuerfel> <20110909193010.GA2993@opensource.wolfsonmicro.com> <20110909205645.GA16355@n2100.arm.linux.org.uk> Message-ID: <201109102237.15193.arnd@arndb.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Friday 09 September 2011, Russell King - ARM Linux wrote: > That's just twisted and utterly insane - adding more code for precisely > zero benefit what so ever. Think about it - the device tree is already > creating platform devices for entries in the device tree file. What's > the point of having this special ASoC code look up the platform compatible > property in a table of strings to find a different string to manually > create a device with. Why not just add the bloody device to the DT > file in the first place? That's partly what DT is there for - to create > platform specific struct devices. Exactly. No driver or (worse) user program should ever need to look at the top-level compatible property. When you want information about a localized part of the system (e.g. the ASoC components), you should look up the information for that component. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934080Ab1IJUhi (ORCPT ); Sat, 10 Sep 2011 16:37:38 -0400 Received: from moutng.kundenserver.de ([212.227.126.186]:55250 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933943Ab1IJUh2 (ORCPT ); Sat, 10 Sep 2011 16:37:28 -0400 From: Arnd Bergmann To: "Russell King - ARM Linux" Subject: Re: [PATCH v2] ASoC: omap: convert per-board modules to platform drivers Date: Sat, 10 Sep 2011 22:37:15 +0200 User-Agent: KMail/1.12.2 (Linux/2.6.35-22-generic; KDE/4.3.2; x86_64; ; ) Cc: Mark Brown , Grant Likely , alsa-devel@alsa-project.org, Liam Girdwood , Tony Lindgren , Jassi Brar , linux-kernel@vger.kernel.org, Jaroslav Kysela , Takashi Iwai , Jarkko Nikula , linaro-dev@lists.linaro.org, linux-omap@vger.kernel.org, Mans Rullgard , linux-arm-kernel@lists.infradead.org References: <3110288.bQbb0H2ME1@wuerfel> <20110909193010.GA2993@opensource.wolfsonmicro.com> <20110909205645.GA16355@n2100.arm.linux.org.uk> In-Reply-To: <20110909205645.GA16355@n2100.arm.linux.org.uk> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201109102237.15193.arnd@arndb.de> X-Provags-ID: V02:K0:1AcxefCY7deri8HivwRWXo/v8vCx1w+o37Pb0jqbAoT K7SlcpU6Z1D4aEJlf1inrciy0F7A0LPJrfV+WF7q6KHDVE+12G moAiTdCXQyiZ79OZoYijJeSQ1GmYflG+SSLlkGImEqwMURZyT+ vExQS9H0UB1OCSYqVAcv5zlnnL+3rI984caBLm5pzBPX9D4aSP F+2AsnCYH7GJXPNG2KsPFEong7nmADDpMTNK/ydqb2pxK+IlXR UX1a3kzLKRwOGTU7cHxIQscWGFWRG129s74U++65VTffiq3Y79 BFkVkqoP3oB35OqpKmOa1unW5zmYc9eH2MHu42tmh0r//wxhqO jvGaKfFeNL5Y7igtetWw= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 09 September 2011, Russell King - ARM Linux wrote: > That's just twisted and utterly insane - adding more code for precisely > zero benefit what so ever. Think about it - the device tree is already > creating platform devices for entries in the device tree file. What's > the point of having this special ASoC code look up the platform compatible > property in a table of strings to find a different string to manually > create a device with. Why not just add the bloody device to the DT > file in the first place? That's partly what DT is there for - to create > platform specific struct devices. Exactly. No driver or (worse) user program should ever need to look at the top-level compatible property. When you want information about a localized part of the system (e.g. the ASoC components), you should look up the information for that component. Arnd