All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joel Becker <jlbec@evilplan.org>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] Can recovery be done in process context (as opposed to kthread)?
Date: Sun, 11 Sep 2011 01:45:23 -0700	[thread overview]
Message-ID: <20110911084522.GC2520@noexit.corp.google.com> (raw)
In-Reply-To: <CAJtY7HVYZ3Uoy0QzBpUsrK68O9C6iUPkBe_YP6JCRskGHao9GA@mail.gmail.com>

On Fri, Sep 09, 2011 at 05:22:49PM -0500, Goldwyn Rodrigues wrote:
> Hi,
> 
> I finally got back to improve the recovery procedure by offloading
> work to work queues. However, I would like to know if we can
> completely do away with ocfs2rec kthread. The process would just mark
> the nodes which need recovery and offload the work on the work queues
> and wait until all is over.
> 
> The reason for doing it this way is to make the mount process
> killable. Currently the dlm locks are taken by ocfs2rec kthread while
> the mount waits in uninterruptible sleep while the recovery happens.

	If the mount dies, but then actually succeeds in the
background...that's weird and violates the Principle of Least Surprise.

Joel

-- 

"Conservative, n.  A statesman who is enamoured of existing evils,
 as distinguished from the Liberal, who wishes to replace them
 with others."
	- Ambrose Bierce, The Devil's Dictionary

			http://www.jlbec.org/
			jlbec at evilplan.org

      parent reply	other threads:[~2011-09-11  8:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-09 22:22 [Ocfs2-devel] Can recovery be done in process context (as opposed to kthread)? Goldwyn Rodrigues
2011-09-10 14:29 ` Sunil Mushran
2011-09-11  8:45 ` Joel Becker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110911084522.GC2520@noexit.corp.google.com \
    --to=jlbec@evilplan.org \
    --cc=ocfs2-devel@oss.oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.