From: Christoph Hellwig <hch@infradead.org>
To: Jens Axboe <jaxboe@fusionio.com>
Cc: Christoph Hellwig <hch@infradead.org>,
"Sam Bradshaw (sbradshaw)" <sbradshaw@micron.com>,
"alan@lxorguk.ukuu.org.uk" <alan@lxorguk.ukuu.org.uk>,
"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Jeff Garzik <jgarzik@pobox.com>,
"jmoyer@redhat.com" <jmoyer@redhat.com>,
"Asai Thambi Samymuthu Pattrayasamy (asamymuthupa) [CONTRACTOR]"
<asamymuthupa@micron.com>
Subject: Re: [PATCH v4] drivers/block/mtip32xx: Adding new driver mtip32xx
Date: Mon, 12 Sep 2011 11:02:28 -0400 [thread overview]
Message-ID: <20110912150228.GA5771@infradead.org> (raw)
In-Reply-To: <4E69D519.8070802@fusionio.com>
On Fri, Sep 09, 2011 at 10:58:01AM +0200, Jens Axboe wrote:
> > Documentation/block/writeback_cache_control.txt file is the canonical
> > resource. Implementing your driver at the make_request layer
> > unfortunately means you will have to do all the hard work yourself.
> > - also the call to blk_queue_flush(queue, 0); from ->make_request for
> > a non-data request is completely wrong.
>
> I noticed both of these flush/fua problems too and have fixed them up.
I still can't find any fixes in your repository.
next prev parent reply other threads:[~2011-09-12 15:02 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-11 18:52 [PATCH v3 2/3] drivers/block/mtip32xx: Adding source for hardware related operations Asai Thambi Samymuthu Pattrayasamy (asamymuthupa) [CONTRACTOR]
2011-08-11 18:52 ` Asai Thambi Samymuthu Pattrayasamy (asamymuthupa) [CONTRACTOR]
2011-08-12 8:42 ` Jens Axboe
2011-08-18 0:18 ` Asai Thambi S P
2011-08-22 21:28 ` [PATCH v4] drivers/block/mtip32xx: Adding new driver mtip32xx Sam Bradshaw (sbradshaw)
2011-08-22 21:28 ` Sam Bradshaw (sbradshaw)
2011-09-01 19:43 ` Jeff Moyer
2011-09-01 19:43 ` Jeff Moyer
2011-09-01 19:46 ` Jens Axboe
2011-09-09 8:54 ` Christoph Hellwig
2011-09-09 8:58 ` Jens Axboe
2011-09-09 9:02 ` Christoph Hellwig
2011-09-09 15:10 ` Sam Bradshaw (sbradshaw)
2011-09-09 15:10 ` Sam Bradshaw (sbradshaw)
2011-09-12 15:02 ` Christoph Hellwig [this message]
2011-09-12 18:25 ` Jens Axboe
2011-09-30 13:33 ` Christoph Hellwig
2011-09-30 19:45 ` Asai Thambi S P
2011-09-30 21:20 ` Jens Axboe
2011-09-30 19:49 ` Asai Thambi S P
2011-09-13 12:49 ` Christoph Hellwig
2011-09-13 16:46 ` Eric Seppanen
2011-09-13 21:03 ` Jens Axboe
[not found] <2A9BE4FF6209B644B6F8EB62DE6AEA1E07765C71@ntxfrembx01.micron.com>
2011-09-01 22:23 ` Sam Bradshaw
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110912150228.GA5771@infradead.org \
--to=hch@infradead.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=asamymuthupa@micron.com \
--cc=jaxboe@fusionio.com \
--cc=jgarzik@pobox.com \
--cc=jmoyer@redhat.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sbradshaw@micron.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.