From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Thornber Subject: Re: [PATCH] dm-thin: Fix multiple bugs with reference management Date: Mon, 12 Sep 2011 18:08:18 +0100 Message-ID: <20110912170817.GA26619@ubuntu> References: Reply-To: device-mapper development Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: Mikulas Patocka Cc: dm-devel@redhat.com List-Id: dm-devel.ids On Mon, Sep 12, 2011 at 12:03:31PM -0400, Mikulas Patocka wrote: > Hi > > This is a major cleanup+bugfix of reference count management. Test it with > your testsuite. Right, we've got 2 patches here really. The first replaces a spinlock with a mutex and lifts it to remove a couple of race conditions. All good, I've prefixed the functions that should be called with this lock held with '__' as usual. The second moves registration to the constructor and destructor rather than suspend/resume. I know you were asking about this earlier, and I think this was a hang over from when the pool and target objects were the same thing, and we couldn't have two targets registered at once when reloading a table. Your change is clearly simpler. All tests pass. Merged and pushed. Thanks, - Joe