From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: fix swizzling on gen6+ Date: Mon, 12 Sep 2011 22:37:14 +0200 Message-ID: <20110912203714.GC2830@phenom.ffwll.local> References: <1315853356-10330-1-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-fx0-f49.google.com (mail-fx0-f49.google.com [209.85.161.49]) by gabe.freedesktop.org (Postfix) with ESMTP id 149769E80D for ; Mon, 12 Sep 2011 13:36:49 -0700 (PDT) Received: by fxg7 with SMTP id 7so1554839fxg.36 for ; Mon, 12 Sep 2011 13:36:49 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Mon, Sep 12, 2011 at 09:13:39PM +0100, Chris Wilson wrote: > On Mon, 12 Sep 2011 20:49:16 +0200, Daniel Vetter wrote: > > Fixes tests/gem_tiled_pread on my snb. I know, mesa doesn't use this > > on gen6+, but I also hate failing testcases. > > Hmm, I thought gen6 also has DRAM configuration registers that we were > meant to set and to follow. Not that I could actually find the > cross-references! I've been surprised that it works and scared > to poke too hard just in case it was broken underneath. ;-) Well, I've checked with my ilk and snb, and now it works for both. ymmv. The other options is to return SWIZZLE_UNKOWN back to userspace and disable the tests on gen5+. I don't care too much either way, but I think making it work is less risky. And now that qa actually runs our tests, we might even catch this earlier. -Daniel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48