From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Scott Jiang <scott.jiang.linux@gmail.com>
Cc: Takashi Iwai <tiwai@suse.de>,
uclinux-dist-devel@blackfin.uclinux.org,
alsa-devel@alsa-project.org
Subject: Re: [PATCH v2]ASoC:blackfin:add ad73311 card driver name
Date: Tue, 13 Sep 2011 11:53:28 +0100 [thread overview]
Message-ID: <20110913105328.GA11214@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1315940366-20515-1-git-send-email-scott.jiang.linux@gmail.com>
On Tue, Sep 13, 2011 at 02:59:26PM -0400, Scott Jiang wrote:
> Add driver_name in snd_soc_card, asoc will copy this name to driver field of snd_card.
> ALSA lib need this info to load the proper card config.
> static struct snd_soc_card bf5xx_ad73311 = {
> .name = "bfin-ad73311",
> + .driver_name = "AD73311",
All my comments about the previous revision of the patch continue to
apply here. The changlog doesn't explain the issue well (the driver
should already end up with a unique name) and the name you've picked
is less distinctive than the existing name.
next prev parent reply other threads:[~2011-09-13 10:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-13 18:59 [PATCH v2]ASoC:blackfin:add ad73311 card driver name Scott Jiang
2011-09-13 10:53 ` Mark Brown [this message]
2011-09-14 3:27 ` Scott Jiang
2011-09-15 10:00 ` Mark Brown
2011-09-16 3:53 ` Scott Jiang
2011-09-16 9:47 ` Mark Brown
2011-09-13 16:11 ` Liam Girdwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110913105328.GA11214@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=scott.jiang.linux@gmail.com \
--cc=tiwai@suse.de \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.