From: Ben Widawsky <ben@bwidawsk.net>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2 v3] drm/i915: Dumb down the semaphore logic
Date: Wed, 14 Sep 2011 09:56:42 -0700 [thread overview]
Message-ID: <20110914095642.555adc39@bwidawsk.net> (raw)
In-Reply-To: <20110914074050.GA2832@phenom.ffwll.local>
On Wed, 14 Sep 2011 09:40:50 +0200
Daniel Vetter <daniel@ffwll.ch> wrote:
Paraphrasing:
>> PATCH
> The code is too bloated
It adds bloat, I agree. I haven't run any tests, but I can't imagine it
has a runtime impact. Your suggestions feel a lot like the existing code
to me, which was not easy to digest.
My goal was to make the code easier to understand, and removing the
black magic was just part of that. To me it's the most obvious way to
understand how the semaphores work, though I could be in the minority.
It also provides an easy way to put per ring debug, add new rings, and
disable/enable semaphores for a given ring (your idea, which I really
like). I don't feel strongly enough about it to argue further than that.
I'm cool with letting the patches die if others don't agree.
Ben
prev parent reply other threads:[~2011-09-14 16:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-14 4:11 [PATCH 1/2 v3] drm/i915: Dumb down the semaphore logic Ben Widawsky
2011-09-14 4:11 ` [PATCH 2/2 v3] drm/i915: tracepoints for semaphores Ben Widawsky
2011-09-14 7:40 ` [PATCH 1/2 v3] drm/i915: Dumb down the semaphore logic Daniel Vetter
2011-09-14 16:56 ` Ben Widawsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110914095642.555adc39@bwidawsk.net \
--to=ben@bwidawsk.net \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.