From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:57556)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1R3wRD-00016L-MR
	for qemu-devel@nongnu.org; Wed, 14 Sep 2011 16:52:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1R3wRC-00021Z-F1
	for qemu-devel@nongnu.org; Wed, 14 Sep 2011 16:52:07 -0400
Received: from mail-fx0-f45.google.com ([209.85.161.45]:51995)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1R3wRC-00021V-8X
	for qemu-devel@nongnu.org; Wed, 14 Sep 2011 16:52:06 -0400
Received: by fxh13 with SMTP id 13so2098812fxh.4
	for <qemu-devel@nongnu.org>; Wed, 14 Sep 2011 13:52:05 -0700 (PDT)
Date: Wed, 14 Sep 2011 22:52:00 +0200
From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Message-ID: <20110914205200.GD17136@zapo>
References: <1315832873-18976-1-git-send-email-avi@redhat.com>
	<4E709763.1080805@redhat.com> <4E70D40D.108@googlemail.com>
	<4E710BF2.9060404@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <4E710BF2.9060404@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] mips_malta: move i8259 initialization
 after piix4 initialization
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: hpoussin@reactos.org, Andreas =?iso-8859-1?Q?F=E4rber?= <planche2k@googlemail.com>, qemu-devel@nongnu.org

On Wed, Sep 14, 2011 at 11:17:54PM +0300, Avi Kivity wrote:
> On 09/14/2011 07:19 PM, Andreas Färber wrote:
> >>
> >>  Can this please be reviewed?  It's in the front of the memory queue
> >>  logjam.
> >
> >With or without this patch, the mips and mipsel test images on qemu.org
> >produce no output at all, on x64 host.
> >
> 
> AFAICT this problem predates the memory API.  I'm looking more for
> criticism on the approach.

Hi, i think the images on the wiki are meant to run on a -M mips board.
Maybe the scripts predate a change to Malta as default board, don't know.

The patch looks OK to me to, but you could maybe put a comment in the code
to explain the indirection.

Cheers