From: Paul Eggleton <paul.eggleton@linux.intel.com>
To: Martin Jansa <martin.jansa@gmail.com>
Cc: openembedded-devel@lists.openembedded.org
Subject: Re: [meta-handheld][PATCH] linux-kexecboot: move defconfigs to linux-kexecboot-2.6.39
Date: Thu, 15 Sep 2011 00:50:33 +0100 [thread overview]
Message-ID: <201109150050.33494.paul.eggleton@linux.intel.com> (raw)
In-Reply-To: <1315307566-15579-1-git-send-email-Martin.Jansa@gmail.com>
On Tuesday 06 September 2011 12:12:46 Martin Jansa wrote:
> * to make room in linux-kexecboot directory for 3.1.0-rc5 defconfigs I've
> prepared 3.1.0-rc5 recipes are here:
> https://gitorious.org/shr/meta-handheld/commits/jansa/spitz
> will send them to after testing and when git.kernel.org is back online
I'm not taking this, for several reasons:
1) I'm willing to be reasonably relaxed about commit messages for meta-
handheld, but they should at least explain why the change is being made and
not contain extraneous information (e.g. the last part of your message above -
this ought to be in a cover letter or a reply if it's easier for you.)
2) Please use the -M option to detect moves, so that renames with no changes
are obvious.
3) This patch alone doesn't appear to do anything valuable; however, in a
series with your forthcoming patch it will, so I'll be more than happy to
apply it then assuming the previous items are tidied up.
(Sorry it took so long to get back to you with this.)
Cheers,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
next prev parent reply other threads:[~2011-09-14 23:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-06 11:12 [meta-handheld][PATCH] linux-kexecboot: move defconfigs to linux-kexecboot-2.6.39 Martin Jansa
2011-09-14 23:50 ` Paul Eggleton [this message]
2011-09-15 9:25 ` [meta-handheld][PATCH 0/3] Pull request #2 Martin Jansa
2011-09-15 9:26 ` [meta-handheld][PATCH 1/3] linux-kexecboot: move defconfig to linux-kexecboot-2.6.39 Martin Jansa
2011-09-15 9:26 ` [meta-handheld][PATCH 2/3] linux(-kexecboot): add recipes for git version 3.1.0-rc6 Martin Jansa
2011-09-15 9:26 ` [meta-handheld][PATCH 3/3] linux_git: set CMDLINE_DEBUG to debug for git version Martin Jansa
2011-09-17 13:56 ` [meta-handheld][PATCH 0/3] Pull request #2 Paul Eggleton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201109150050.33494.paul.eggleton@linux.intel.com \
--to=paul.eggleton@linux.intel.com \
--cc=martin.jansa@gmail.com \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.