From: Ben Widawsky <ben@bwidawsk.net>
To: intel-gfx@lists.freedesktop.org
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH 1/2 v4] drm/i915: Dumb down the semaphore logic
Date: Thu, 15 Sep 2011 03:59:13 +0000 [thread overview]
Message-ID: <20110915035913.GB25691@cloud01> (raw)
In-Reply-To: <1316057568-8233-1-git-send-email-ben@bwidawsk.net>
On Wed, Sep 14, 2011 at 08:32:47PM -0700, Ben Widawsky wrote:
> While I think the previous code is correct, it was hard to follow and
> hard to debug. Since we already have a ring abstraction, might as well
> use it to handle the semaphore updates and compares.
>
> I don't expect this code to make semaphores better or worse, but you
> never know...
>
> v2:
> Remove magic per Keith's suggestions.
> Ran Daniel's gem_ring_sync_loop test on this.
>
> v3:
> Ignored one of Keith's suggestions.
>
> v4:
> Removed some bloat per Daniel's recommendation.
Just to clarify, I think I like the existing code a bit better than what
the code looked like with Daniel's other recommendation to cut out the
per ring sync_to function. If he shows me something good, there will be
a v5, I guess.
prev parent reply other threads:[~2011-09-15 3:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-15 3:32 [PATCH 1/2 v4] drm/i915: Dumb down the semaphore logic Ben Widawsky
2011-09-15 3:32 ` [PATCH 2/2 v4] drm/i915: tracepoints for semaphores Ben Widawsky
2011-09-15 3:59 ` Ben Widawsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110915035913.GB25691@cloud01 \
--to=ben@bwidawsk.net \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.