From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olaf Hering Subject: Re: [PATCH 6 of 9] xenpaging: add evict_pages function Date: Thu, 15 Sep 2011 11:17:23 +0200 Message-ID: <20110915091723.GA18591@aepfle.de> References: <3a3a5979b799d9488021.1316067394@probook.site> <1316074602.25935.4.camel@cthulhu.hellion.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: George Dunlap Cc: "xen-devel@lists.xensource.com" , Ian Campbell List-Id: xen-devel@lists.xenproject.org On Thu, Sep 15, George Dunlap wrote: > On Thu, Sep 15, 2011 at 9:16 AM, Ian Campbell wrote: > > On Thu, 2011-09-15 at 02:16 -0400, Olaf Hering wrote: > >> # HG changeset patch > >> # User Olaf Hering > >> # Date 1316067230 -7200 > >> # Node ID 3a3a5979b799d948802183d10d65894ee84a872f > >> # Parent  6beca8cbc2c92900859712f8738db17084bcebdb > >> xenpaging: add evict_pages function > >> > >> Add new function to evict a couple of pages. > > > > Do you really mean "a couple" here? (that generally means exactly two). > > LIterally "couple" means two, but at least in US idiom, "a couple of > [foo]" means a small indeterminate number, usually 2-4. > > In any case, a more precise description seems like a better idea -- it > looks like it takes an argument for the number of pages to evict; and > it's not adding a new function, it's pulling existing code into a > function. So, "Pull eviction loop into a function" would probably be > a better description. Thanks to both of you, I will improve the description. Olaf