From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Thu, 15 Sep 2011 12:41:32 +0200 Subject: [PATCH 3/5] of/irq: introduce of_irq_init In-Reply-To: <1316017900-19918-4-git-send-email-robherring2@gmail.com> References: <1316017900-19918-1-git-send-email-robherring2@gmail.com> <1316017900-19918-4-git-send-email-robherring2@gmail.com> Message-ID: <201109151241.32951.arnd@arndb.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wednesday 14 September 2011, Rob Herring wrote: > From: Rob Herring > > of_irq_init will scan the devicetree for matching interrupt controller > nodes. Then it calls an initialization function for each found controller > in the proper order with parent nodes initialized before child nodes. > > Based on initial pseudo code from Grant Likely. > > Signed-off-by: Rob Herring > Cc: Grant Likely Looks good to me, Acked-by: Arnd Bergmann > + > +struct intc_desc { > + struct list_head list; > + struct device_node *dev; > + struct device_node *parent; > +}; One tiny comment: how about naming the parent 'interrupt_parent'? While reading through the code, I was confused for a short time until I figured out what this is about. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932765Ab1IOKlq (ORCPT ); Thu, 15 Sep 2011 06:41:46 -0400 Received: from moutng.kundenserver.de ([212.227.126.187]:57929 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932606Ab1IOKlp (ORCPT ); Thu, 15 Sep 2011 06:41:45 -0400 From: Arnd Bergmann To: Rob Herring Subject: Re: [PATCH 3/5] of/irq: introduce of_irq_init Date: Thu, 15 Sep 2011 12:41:32 +0200 User-Agent: KMail/1.12.2 (Linux/2.6.35-22-generic; KDE/4.3.2; x86_64; ; ) Cc: linux-arm-kernel@lists.infradead.org, devicetree-discuss@lists.ozlabs.org, linux-kernel@vger.kernel.org, grant.likely@secretlab.ca, marc.zyngier@arm.com, thomas.abraham@linaro.org, jamie@jamieiles.com, b-cousson@ti.com, shawn.guo@linaro.org, Rob Herring References: <1316017900-19918-1-git-send-email-robherring2@gmail.com> <1316017900-19918-4-git-send-email-robherring2@gmail.com> In-Reply-To: <1316017900-19918-4-git-send-email-robherring2@gmail.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201109151241.32951.arnd@arndb.de> X-Provags-ID: V02:K0:rIrMwXHZ4in8UTb7jT6IU+o1ebLB1oKTdzvVxGD5mH5 /sXD4Gv/8OTLuE5BN1q57EVnTFQIHtnEw3qrTN87WdzY5yOoWt 7qbQksCM0CvIwek0wOLo8Hu1YXRNwESbQbtPF6Gl5N2ln3+ATX H1uLabMolqR8TlXyzSuJZzecEPhT6QpbGytf+VwrpFM3NDNjuX FtPiWoriQ1xur+8kekR8y4XasKiF4hR39XkUnGS8FlLF2Wq4F/ LoOFYrguYTTKC+8fuDmFSEgypgnuET3lWseMbiS5Yzq5qlx28J celWzpH5S88DCYqYNE7kDhWe9oBRd2a4DRMCmgwK4saSiYum7b 1e5AoUfMhkmLhgHFn23s= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 14 September 2011, Rob Herring wrote: > From: Rob Herring > > of_irq_init will scan the devicetree for matching interrupt controller > nodes. Then it calls an initialization function for each found controller > in the proper order with parent nodes initialized before child nodes. > > Based on initial pseudo code from Grant Likely. > > Signed-off-by: Rob Herring > Cc: Grant Likely Looks good to me, Acked-by: Arnd Bergmann > + > +struct intc_desc { > + struct list_head list; > + struct device_node *dev; > + struct device_node *parent; > +}; One tiny comment: how about naming the parent 'interrupt_parent'? While reading through the code, I was confused for a short time until I figured out what this is about. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH 3/5] of/irq: introduce of_irq_init Date: Thu, 15 Sep 2011 12:41:32 +0200 Message-ID: <201109151241.32951.arnd@arndb.de> References: <1316017900-19918-1-git-send-email-robherring2@gmail.com> <1316017900-19918-4-git-send-email-robherring2@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1316017900-19918-4-git-send-email-robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Rob Herring Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Rob Herring , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On Wednesday 14 September 2011, Rob Herring wrote: > From: Rob Herring > > of_irq_init will scan the devicetree for matching interrupt controller > nodes. Then it calls an initialization function for each found controller > in the proper order with parent nodes initialized before child nodes. > > Based on initial pseudo code from Grant Likely. > > Signed-off-by: Rob Herring > Cc: Grant Likely Looks good to me, Acked-by: Arnd Bergmann > + > +struct intc_desc { > + struct list_head list; > + struct device_node *dev; > + struct device_node *parent; > +}; One tiny comment: how about naming the parent 'interrupt_parent'? While reading through the code, I was confused for a short time until I figured out what this is about. Arnd