From: Ted Ts'o <tytso@mit.edu>
To: Amir Goldstein <amir73il@gmail.com>
Cc: "Darrick J. Wong" <djwong@us.ibm.com>, linux-ext4@vger.kernel.org
Subject: Re: On-disk field assignments for metadata checksum and snapshots
Date: Thu, 15 Sep 2011 13:57:55 -0400 [thread overview]
Message-ID: <20110915175755.GK15782@thunk.org> (raw)
In-Reply-To: <CAOQ4uxihCk=o2C8Htzn5JgnbZ3zRSS+JhaiCw=gcDdgLojd94Q@mail.gmail.com>
On Thu, Sep 15, 2011 at 07:01:47PM +0300, Amir Goldstein wrote:
> > + { E2P_FEATURE_COMPAT, EXT2_FEATURE_COMPAT_EXCLUDE_BITMAP,
> > + "snapshot" },
>
> The feature name should read "exclude_bitmap".
> This is a COMPAT feature which should be set by default on every mkfs.ext4.
> The "has_snapshot" (or "snapshots") feature is a RO_COMPAT feature, which
> can be turned on and off, depending on whether you want to enable or
> disable snapshots.
Yeah, I was trying to use a name which would be a bit more descriptive
than "exclude_bitmap", but I agree that will get very confusing with
the "has_snapshot" feature name.
- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-09-15 17:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1R4Dby-0005qO-I2@tytso-glaptop.cam.corp.google.com>
2011-09-15 16:01 ` On-disk field assignments for metadata checksum and snapshots Amir Goldstein
2011-09-15 17:57 ` Ted Ts'o [this message]
2011-09-16 6:52 ` Amir Goldstein
2011-09-16 11:35 ` Yongqiang Yang
2011-09-16 11:48 ` Amir Goldstein
2011-09-16 12:00 ` Yongqiang Yang
2011-09-16 12:12 ` Amir Goldstein
2011-09-16 14:31 ` Ted Ts'o
2011-09-15 16:55 ` Darrick J. Wong
2011-09-15 17:19 ` Darrick J. Wong
2011-09-15 19:10 ` Andreas Dilger
2011-09-15 20:05 ` Ted Ts'o
2011-09-15 20:05 ` Darrick J. Wong
2011-09-15 23:26 ` Andreas Dilger
2011-09-15 17:56 ` Ted Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110915175755.GK15782@thunk.org \
--to=tytso@mit.edu \
--cc=amir73il@gmail.com \
--cc=djwong@us.ibm.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.