From: Andi Kleen <andi@firstfloor.org>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Andi Kleen <andi@firstfloor.org>, Thomas Meyer <thomas@m3y3r.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sys_poll(): fix function definition/negative timeout values
Date: Thu, 15 Sep 2011 20:12:42 +0200 [thread overview]
Message-ID: <20110915181242.GZ7761@one.firstfloor.org> (raw)
In-Reply-To: <1316109917.2492.3.camel@edumazet-laptop>
On Thu, Sep 15, 2011 at 08:05:17PM +0200, Eric Dumazet wrote:
> Le jeudi 15 septembre 2011 à 10:47 -0700, Andi Kleen a écrit :
> > Thomas Meyer <thomas@m3y3r.de> writes:
> >
> > > Fix negative timeout values for x86 userland on x86_64 kernels.
> > > Align sys_poll() definition to glibc's definition.
> >
> > Nack. Please write a compat wrapper that sign extends.
> >
>
> Why ?
Because we shouldn't change existing interfaces and there could
be valid reasons on 64bit for really long delays.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
next prev parent reply other threads:[~2011-09-15 18:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-15 12:45 [PATCH] sys_poll(): fix function definition/negative timeout values Thomas Meyer
2011-09-15 17:47 ` Andi Kleen
2011-09-15 18:05 ` Eric Dumazet
2011-09-15 18:12 ` Andi Kleen [this message]
2011-09-15 18:21 ` Eric Dumazet
2011-10-06 23:01 ` Andrew Morton
2011-09-16 17:04 ` Valdis.Kletnieks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110915181242.GZ7761@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=thomas@m3y3r.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.