From: Ted Ts'o <tytso@mit.edu>
To: amir73il@users.sourceforge.net
Cc: linux-ext4@vger.kernel.org, Amir Goldstein <amir73il@users.sf.net>
Subject: Re: [PATCH] libext2fs: fix the range validation in bitmap_range2 funcs
Date: Thu, 15 Sep 2011 22:23:59 -0400 [thread overview]
Message-ID: <20110916022359.GO28181@thunk.org> (raw)
In-Reply-To: <1308064592-29935-1-git-send-email-amir73il@users.sourceforge.net>
On Tue, Jun 14, 2011 at 06:16:32PM +0300, amir73il@users.sourceforge.net wrote:
> From: Amir Goldstein <amir73il@users.sf.net>
>
> The condition ((start+num) & ~0xffffffffULL) in bitmap_ragne2
> and generic_bmap_range funcs in get_bitmap64.c was wrong and
> inconsistent with the condition (start+num-1 > bmap->real_end)
> in generic_bitmap_range funcs in get_bitmap.c.
>
> I got the following error from tune2fs on a 16TB fs:
> Illegal block number passed to ext2fs_unmark_block_bitmap #4294967295
> for block bitmap for 16TB.img
> tune2fs: Invalid argument while reading bitmaps
>
> Fix to condition to ((start+num-1) & ~0xffffffffULL), because
> the bit (start+num) is not going to be changed by the funcs.
>
> Signed-off-by: Amir Goldstein <amir73il@users.sf.net>
Applied, thanks.
- Ted
prev parent reply other threads:[~2011-09-16 2:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-14 15:16 [PATCH] libext2fs: fix the range validation in bitmap_range2 funcs amir73il
2011-09-15 6:54 ` Amir G.
2011-09-16 2:23 ` Ted Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110916022359.GO28181@thunk.org \
--to=tytso@mit.edu \
--cc=amir73il@users.sf.net \
--cc=amir73il@users.sourceforge.net \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.