From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 5/5] drm/i915: tracepoints for semaphores Date: Fri, 16 Sep 2011 11:07:29 +0200 Message-ID: <20110916090729.GC2873@phenom.ffwll.local> References: <1316138941-6537-1-git-send-email-ben@bwidawsk.net> <1316138941-6537-6-git-send-email-ben@bwidawsk.net> <20110916075853.GB2873@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ww0-f43.google.com (mail-ww0-f43.google.com [74.125.82.43]) by gabe.freedesktop.org (Postfix) with ESMTP id E0CF3A0A49 for ; Fri, 16 Sep 2011 02:07:02 -0700 (PDT) Received: by wwf27 with SMTP id 27so4145934wwf.12 for ; Fri, 16 Sep 2011 02:07:02 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: Ben Widawsky , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, Sep 16, 2011 at 09:37:41AM +0100, Chris Wilson wrote: > On Fri, 16 Sep 2011 09:58:53 +0200, Daniel Vetter wrote: > > We already have trace_i915_gem_request_add in i915_add_request which is > > essentially giving out the same information (well, minus the hopefully > > correct singal_mbox reg addresses). I think we can drop this one. > > I thought that as well, but then realised that a complete set of ring > tracepoints would be useful independent of the request/object > tracepoints. > > A couple of tracepoints on the gen6 paths is insufficients. ;-) Well, I've quickly reviewed them and I think we're mostly covered. Many of the tracepoints are called from generic code i915_gem.c right before/after calling into the chipset-specific ringbuffer functions. -Daniel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48