All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ted Ts'o <tytso@mit.edu>
To: Andreas Dilger <adilger@dilger.ca>
Cc: Ext4 Developers List <linux-ext4@vger.kernel.org>,
	"Darrick J. Wong" <djwong@us.ibm.com>,
	Amir Goldstein <amir73il@gmail.com>
Subject: Re: [PATCH 1/2] libext2fs: add metadata checksum and snapshot feature flags
Date: Fri, 16 Sep 2011 10:28:25 -0400	[thread overview]
Message-ID: <20110916142825.GB6342@thunk.org> (raw)
In-Reply-To: <036188D0-DA3B-4DD1-A097-F0B6AC4B4BB4@dilger.ca>

On Thu, Sep 15, 2011 at 09:57:33PM -0600, Andreas Dilger wrote:
> True, but at the same time is there a reason _not_ to put the checksum
> at the end?  For the superblock in particular it seems easy to do and
> simplifies the code either way.

For the superblock, OK.  I'll buy that and I'll make the change so
that tail end of the superblock looks like this:

     __u32    s_overhead_blocks;      /* overhead blocks/clusters in fs */
     __u32   s_reserved[108];        /* Padding to the end of the block */
     __u32   s_checksum;	     	/* crc32c(superblock) */
};

							- Ted



  reply	other threads:[~2011-09-16 14:28 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-15 22:50 [PATCH 0/2] On disk format changes - V3 Theodore Ts'o
2011-09-15 22:50 ` [PATCH 1/2] libext2fs: add metadata checksum and snapshot feature flags Theodore Ts'o
2011-09-15 23:09   ` Andreas Dilger
2011-09-15 23:11     ` Ted Ts'o
2011-09-15 23:34       ` Andreas Dilger
2011-09-15 23:41         ` Ted Ts'o
2011-09-16  0:09           ` Andreas Dilger
2011-09-16  0:56             ` Darrick J. Wong
2011-09-16  4:03               ` Andreas Dilger
2011-09-16  1:06             ` Ted Ts'o
2011-09-16  3:57               ` Andreas Dilger
2011-09-16 14:28                 ` Ted Ts'o [this message]
2011-09-19 18:58   ` Darrick J. Wong
2011-09-20 18:56   ` Darrick J. Wong
2011-09-21  8:03     ` Amir Goldstein
2011-09-21 20:40       ` Darrick J. Wong
2011-09-22  2:12         ` Amir Goldstein
2011-09-22 19:18           ` Darrick J. Wong
2011-09-23  5:57             ` Amir Goldstein
2011-09-15 22:50 ` [PATCH 2/2] debugfs: add 64-bit support to the set_field commands Theodore Ts'o

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110916142825.GB6342@thunk.org \
    --to=tytso@mit.edu \
    --cc=adilger@dilger.ca \
    --cc=amir73il@gmail.com \
    --cc=djwong@us.ibm.com \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.