From: Vasiliy Kulikov <segoon@openwall.com>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: Pavel Machek <pavel@ucw.cz>, Andrew Morton <akpm00@gmail.com>,
linux-kernel@vger.kernel.org, containers@lists.osdl.org,
linux-fsdevel@vger.kernel.org,
Kirill Shutemov <kirill@shutemov.name>,
Pavel Emelyanov <xemul@parallels.com>,
James Bottomley <jbottomley@parallels.com>,
Nathan Lynch <ntl@pobox.com>, Zan Lynx <zlynx@acm.org>,
Daniel Lezcano <dlezcano@fr.ibm.com>, Tejun Heo <tj@kernel.org>,
Alexey Dobriyan <adobriyan@gmail.com>,
Al Viro <viro@ZenIV.linux.org.uk>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [patch 2/2] fs, proc: Introduce the /proc/<pid>/map_files/ directory v12
Date: Fri, 16 Sep 2011 22:11:46 +0400 [thread overview]
Message-ID: <20110916181146.GA20801@albatros> (raw)
In-Reply-To: <20110916180731.GB8599@sun>
On Fri, Sep 16, 2011 at 22:07 +0400, Cyrill Gorcunov wrote:
> > BTW, not a big deal, but probably you should return -EACCES on
> > !capable() as file presence is not an issue in this case.
> >
> > if (!ptrace_may_access(task, PTRACE_MODE_READ))
> > goto out_notask;
> >
> > status = -EACCES;
> > if (!capable(CAP_SYS_ADMIN))
> > goto out_notask;
> >
> > status = 0;
> >
> >
>
> That's not a proble to fix it actually. So can I fix it and
> put some tage here (Reviewed or something?).
Yep, with CAP_SYS_ADMIN check there should be no issues here.
Reviewed-by: Vasiliy Kulikov <segoon@openwall.com>
Thanks,
--
Vasiliy Kulikov
http://www.openwall.com - bringing security into open computing environments
next prev parent reply other threads:[~2011-09-16 18:11 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-13 21:13 [patch 0/2] symlinks for mapped files in proc Cyrill Gorcunov
2011-09-13 21:14 ` [patch 1/2] fs, proc: Make proc_get_link to use dentry instead of inode Cyrill Gorcunov
2011-09-14 1:37 ` Kirill A. Shutemov
2011-09-13 21:14 ` [patch 2/2] fs, proc: Introduce the /proc/<pid>/map_files/ directory v12 Cyrill Gorcunov
[not found] ` <20110914023428.GA4034@shutemov.name>
2011-09-14 5:54 ` Cyrill Gorcunov
2011-09-14 6:52 ` Andrew Morton
2011-09-14 10:56 ` Cyrill Gorcunov
2011-09-14 11:14 ` Pavel Machek
2011-09-14 11:39 ` Cyrill Gorcunov
2011-09-14 13:44 ` Cyrill Gorcunov
2011-09-14 14:48 ` Vasiliy Kulikov
2011-09-14 14:57 ` Vasiliy Kulikov
2011-09-14 16:00 ` Cyrill Gorcunov
2011-09-14 16:07 ` Vasiliy Kulikov
2011-09-14 16:13 ` Pavel Emelyanov
2011-09-14 16:21 ` Vasiliy Kulikov
2011-09-15 9:14 ` Cyrill Gorcunov
2011-09-15 9:27 ` Vasiliy Kulikov
2011-09-15 10:29 ` Cyrill Gorcunov
2011-09-15 10:56 ` Vasiliy Kulikov
2011-09-15 11:00 ` Cyrill Gorcunov
2011-09-15 20:19 ` Cyrill Gorcunov
2011-09-16 17:56 ` Vasiliy Kulikov
2011-09-16 18:07 ` Cyrill Gorcunov
2011-09-16 18:11 ` Vasiliy Kulikov [this message]
2011-09-16 18:26 ` Cyrill Gorcunov
2011-09-16 18:31 ` Kirill A. Shutemov
2011-09-16 18:40 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110916181146.GA20801@albatros \
--to=segoon@openwall.com \
--cc=adobriyan@gmail.com \
--cc=akpm00@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=containers@lists.osdl.org \
--cc=dlezcano@fr.ibm.com \
--cc=gorcunov@gmail.com \
--cc=jbottomley@parallels.com \
--cc=kirill@shutemov.name \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ntl@pobox.com \
--cc=pavel@ucw.cz \
--cc=tj@kernel.org \
--cc=viro@ZenIV.linux.org.uk \
--cc=xemul@parallels.com \
--cc=zlynx@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.