From: Greg KH <greg@kroah.com>
To: Randy Dunlap <rdunlap@xenotime.net>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Greg KH <gregkh@suse.de>,
driverdevel <devel@driverdev.osuosl.org>,
Andrew Morton <akpm@linux-foundation.org>,
Ian Abbott <abbotti@mev.co.uk>,
Frank Mori Hess <fmhess@users.sourceforge.net>
Subject: Re: [PATCH] staging: fix comedi build when ISA_DMA_API is enabled but COMEDI_PCI is not enabled
Date: Sun, 18 Sep 2011 01:20:48 -0700 [thread overview]
Message-ID: <20110918082048.GA17490@kroah.com> (raw)
In-Reply-To: <20110912145320.GA28855@kroah.com>
On Mon, Sep 12, 2011 at 04:53:20PM +0200, Greg KH wrote:
> On Thu, Sep 08, 2011 at 09:06:17AM -0700, Randy Dunlap wrote:
> > From: Randy Dunlap <rdunlap@xenotime.net>
> >
> > Fix build when CONFIG_ISA_DMA_API is enabled but
> > CONFIG_COMEDI_PCI[_DRIVERS] is not enabled.
> > Fixes these build errors:
> >
> > drivers/staging/comedi/drivers/ni_labpc.c: In function 'labpc_ai_cmd':
> > drivers/staging/comedi/drivers/ni_labpc.c:1351: error: implicit declaration of function 'labpc_suggest_transfer_size'
> > drivers/staging/comedi/drivers/ni_labpc.c: At top level:
> > drivers/staging/comedi/drivers/ni_labpc.c:1802: error: conflicting types for 'labpc_suggest_transfer_size'
> > drivers/staging/comedi/drivers/ni_labpc.c:1351: note: previous implicit declaration of 'labpc_suggest_transfer_size' was here
> >
> > Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
> > ---
> >
> > Greg, I had previously said that this patch was not needed since
> > you had merged a larger patch, but I had another build error which
> > this patch fixes, so it is now needed in mainline.
>
> So this is needed in Linus's tree now? Or in linux-next? It doesn't
> apply to my staging-next tree so I'm confused.
Now dropped from my to-apply queue.
If this is still needed, please resend.
greg k-h
next prev parent reply other threads:[~2011-09-18 8:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-08 16:06 [PATCH] staging: fix comedi build when ISA_DMA_API is enabled but COMEDI_PCI is not enabled Randy Dunlap
2011-09-12 14:53 ` Greg KH
2011-09-18 8:20 ` Greg KH [this message]
2011-09-18 15:02 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110918082048.GA17490@kroah.com \
--to=greg@kroah.com \
--cc=abbotti@mev.co.uk \
--cc=akpm@linux-foundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=fmhess@users.sourceforge.net \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.