From: Arnd Bergmann <arnd@arndb.de>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: Luciano Coelho <coelho@ti.com>,
Randy Dunlap <rdunlap@xenotime.net>,
matti.j.aaltonen@nokia.com, johannes@sipsolutions.net,
linux-kernel@vger.kernel.org, sameo@linux.intel.com,
mchehab@infradead.org, linux-media@vger.kernel.org,
linux-omap@vger.kernel.org, Jean Delvare <khali@linux-fr.org>,
Tony Lindgren <tony@atomide.com>
Subject: Re: [PATCH] mfd: Combine MFD_SUPPORT and MFD_CORE
Date: Mon, 19 Sep 2011 17:06:01 +0200 [thread overview]
Message-ID: <201109191706.01569.arnd@arndb.de> (raw)
In-Reply-To: <20110915171634.GD3523@ponder.secretlab.ca>
On Thursday 15 September 2011, Grant Likely wrote:
> > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> > index 21574bd..1836cdf 100644
> > --- a/drivers/mfd/Kconfig
> > +++ b/drivers/mfd/Kconfig
> > @@ -2,10 +2,9 @@
> > # Multifunction miscellaneous devices
> > #
> >
> > -menuconfig MFD_SUPPORT
> > - bool "Multifunction device drivers"
> > +menuconfig MFD_CORE
> > + tristate "Multifunction device drivers"
> > depends on HAS_IOMEM
> > - default y
>
> Looks like there is a bug here. Kconfig symbols with dependencies
> (HAS_IOMEM) must not ever be selected by other symbols because Kconfig
> doesn't implement a way to resolve them. This patch means that every
> "select MFD_CORE" just assumes that HAS_IOMEM is also selected.
That is probably a fair assumption though. Almost all architectures
set HAS_IOMEM unconditionally, and the other ones (probably just s390)
would not select MFD_CORE.
Note that Samuel already took the other patch in the end, so it doesn't
matter. The patch I posted encloses the entire directory in "if HAS_IOMEM".
Arnd
prev parent reply other threads:[~2011-09-19 15:06 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-29 17:02 Kconfig unmet dependency with RADIO_WL1273 Luciano Coelho
2011-08-29 17:27 ` Randy Dunlap
2011-08-29 18:41 ` [PATCH] mfd: Combine MFD_SUPPORT and MFD_CORE Luciano Coelho
2011-08-29 18:41 ` Luciano Coelho
2011-08-29 18:54 ` Grant Likely
2011-08-29 18:54 ` Grant Likely
2011-08-31 16:18 ` Jean Delvare
2011-08-31 16:49 ` Arnd Bergmann
2011-09-02 11:54 ` Luciano Coelho
2011-09-02 12:37 ` Jean Delvare
2011-09-02 14:43 ` [PATCH 1/2] misc: remove CONFIG_MISC_DEVICES Arnd Bergmann
2011-09-05 12:41 ` Jean Delvare
2011-09-05 14:19 ` Arnd Bergmann
2011-09-05 14:27 ` Jean Delvare
2011-09-18 15:11 ` Randy Dunlap
2011-09-18 15:28 ` Greg KH
2011-09-18 18:45 ` Randy Dunlap
2011-09-19 8:47 ` Arnd Bergmann
2011-09-19 13:07 ` Greg KH
2011-09-19 15:14 ` Arnd Bergmann
2011-09-02 14:43 ` [PATCH 2/2] mfd: remove CONFIG_MFD_SUPPORT Arnd Bergmann
2011-09-05 13:09 ` Jean Delvare
2011-09-15 15:46 ` Samuel Ortiz
2011-09-02 15:49 ` [PATCH] mfd: Combine MFD_SUPPORT and MFD_CORE Arnd Bergmann
2011-09-15 17:16 ` Grant Likely
2011-09-19 15:06 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201109191706.01569.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=coelho@ti.com \
--cc=grant.likely@secretlab.ca \
--cc=johannes@sipsolutions.net \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=matti.j.aaltonen@nokia.com \
--cc=mchehab@infradead.org \
--cc=rdunlap@xenotime.net \
--cc=sameo@linux.intel.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.