From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH] alsa-lib: if card driver name is empty string, use card name instead Date: Tue, 20 Sep 2011 11:03:15 +0100 Message-ID: <20110920100314.GB2387@opensource.wolfsonmicro.com> References: <1316538944-31853-1-git-send-email-scott.jiang.linux@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from opensource2.wolfsonmicro.com (opensource.wolfsonmicro.com [80.75.67.52]) by alsa0.perex.cz (Postfix) with ESMTP id A5A3C10389B for ; Tue, 20 Sep 2011 12:03:16 +0200 (CEST) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Takashi Iwai Cc: uclinux-dist-devel@blackfin.uclinux.org, Scott Jiang , alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org On Tue, Sep 20, 2011 at 09:12:19AM +0200, Takashi Iwai wrote: > Scott Jiang wrote: > > I agree with you, but my driver patch has been rejected by Mark. > That's bad. But it's a rule since over 10 years ago: the driver > should set driver field. Scott, as I've said every time you've posted your patch there's several problems with your patch: - The name you've chosen is really not at all suitable, it doesn't identify the system at all. - This clearly isn't something that affects only one driver - no ASoC driver sets a driver name - so a change to a single driver is clearly not a good solution even for just Blackfin. You need to address these issues, they're both blocking.