From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH] alsa-lib: if card driver name is empty string, use card name instead Date: Tue, 20 Sep 2011 11:53:33 +0100 Message-ID: <20110920105333.GG2387@opensource.wolfsonmicro.com> References: <1316538944-31853-1-git-send-email-scott.jiang.linux@gmail.com> <20110920100314.GB2387@opensource.wolfsonmicro.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from opensource2.wolfsonmicro.com (opensource.wolfsonmicro.com [80.75.67.52]) by alsa0.perex.cz (Postfix) with ESMTP id EF72A1038AE for ; Tue, 20 Sep 2011 12:53:34 +0200 (CEST) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Scott Jiang Cc: Takashi Iwai , uclinux-dist-devel@blackfin.uclinux.org, alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org On Tue, Sep 20, 2011 at 06:36:15PM +0800, Scott Jiang wrote: > 2011/9/20 Mark Brown : > > =A0- This clearly isn't something that affects only one driver - no ASoC > > =A0 driver sets a driver name - so a change to a single driver is clear= ly > > =A0 not a good solution even for just Blackfin. > I thought about this. I wanted to copy codec name to driver name as > before in asoc but I don't think it's a good idea. > Now we can have multicodecs in one card, they may not be the same, right? > If yes, we should add this name in each snd_soc_card. If we want to do that then we need to go round every single machine driver and add a driver name, plus add code in the core which flags cards that don't set one.