From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com,
Liam Girdwood <lrg@ti.cm>
Subject: Re: [PATCH] ASoC: Ensure we generate a card name
Date: Tue, 20 Sep 2011 13:19:14 +0100 [thread overview]
Message-ID: <20110920121913.GC2809@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <s5hr53b1kgw.wl%tiwai@suse.de>
On Tue, Sep 20, 2011 at 02:12:15PM +0200, Takashi Iwai wrote:
> Mark Brown wrote:
> > > Better to replace any letter except [a-zA-Z0-9_] with '_' or drop
> > > them. Use isalnum(), for example.
> > What *are* the rules? The documentation says "driver name" which isn't
> > verbose...
> It's used as an id string, so you can guess.
> Practically, it should be a single word, contain no dangerous letters
> that may screw up the parser.
I'm inclined to just stick with the original patch then, I'd expect that
anything that's problematic for the driver name is also going to be an
issue in the main name field and it's a lot simpler to implement (we
don't have isalnum() in kernel right now and you still need to handle _
and possibly -).
next prev parent reply other threads:[~2011-09-20 12:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-20 10:42 [PATCH] ASoC: Ensure we generate a card name Mark Brown
2011-09-20 10:58 ` Takashi Iwai
2011-09-20 11:03 ` Mark Brown
2011-09-20 12:12 ` Takashi Iwai
2011-09-20 12:19 ` Mark Brown [this message]
2011-09-20 12:51 ` Takashi Iwai
2011-09-20 12:56 ` Mark Brown
2011-09-20 13:02 ` Takashi Iwai
2011-09-20 13:20 ` Mark Brown
2011-09-20 13:30 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110920121913.GC2809@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=lrg@ti.cm \
--cc=patches@opensource.wolfsonmicro.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.