From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH] ASoC: Ensure we generate a card name Date: Tue, 20 Sep 2011 14:20:02 +0100 Message-ID: <20110920132002.GF2809@opensource.wolfsonmicro.com> References: <1316515341-21157-1-git-send-email-broonie@opensource.wolfsonmicro.com> <20110920110355.GI2387@opensource.wolfsonmicro.com> <20110920121913.GC2809@opensource.wolfsonmicro.com> <20110920125646.GD2809@opensource.wolfsonmicro.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from opensource2.wolfsonmicro.com (opensource.wolfsonmicro.com [80.75.67.52]) by alsa0.perex.cz (Postfix) with ESMTP id C65692446E for ; Tue, 20 Sep 2011 15:20:03 +0200 (CEST) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Takashi Iwai Cc: alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com, Liam Girdwood List-Id: alsa-devel@alsa-project.org On Tue, Sep 20, 2011 at 03:02:22PM +0200, Takashi Iwai wrote: > Mark Brown wrote: > > It might not be used by ALSA but it's used by some userspaces to > > identify the card they're running on. > The card->name can contain special letters. This has been so for over > a decade, and won't be changed. Why now need to change this? I'm not suggesting that it should? To be honest I'm quite surprised that the alsa-lib code isn't able to cope with spaces in the driver name in the first places, I'd rather just fix the specific characters it doesn't like.