Re: [Qemu-devel] [ltt-dev] [PATCH 2/3] trace: [ust] Do not use 'm' in event argument names (used by ust macros)

[Mathieu Desnoyers <compudj@krystal.dyndns.org>]

* Lluís Vilanova (vilanova@ac.upc.edu) wrote:
> 
> I don't know about the portability requirements in UST, but if supporting only
> gcc is an option, you can simply use this line in the macro:
> 
>                   void *__tp_cb_data __attribute__((unused));
> 

Done. See commit 34dca3cc6e0b230c988b16117b967a094560f4ed.

> Even with this fixed, there still seem to be problems with events without
> parameters:
> 
>   DECLARE_TRACE(ust_slavio_misc_update_irq_raise, TP_PROTO(void), TP_ARGS());
>   #define trace_slavio_misc_update_irq_raise trace_ust_slavio_misc_update_irq_raise
> 
>   ./trace.h: In function ‘__trace_ust_slavio_misc_update_irq_raise’:
>   ./trace.h:361:1: error: ‘void’ must be the only parameter
>   ./trace.h:361:1: error: expected expression before ‘)’ token
>   ./trace.h:361:1: error: too many arguments to function ‘(void (*)(void *))__tp_it_func’
> 

TRACEPOINT_EVENT_NOARGS(name, TP_FIELDS()) should be used there.

Thanks!

Mathieu

> The debian/testing version of ust is 0.15, and the sources have a ChangeLog with
> this at the top:
> 
>   2011-07-15 ust 0.15
>       * Add backward compability for tracepoint API (still planned for
>         deprecation, but should make the transition smoother).
> 
> 
> Lluis
> 
> -- 
>  "And it's much the same thing with knowledge, for whenever you learn
>  something new, the whole world becomes that much richer."
>  -- The Princess of Pure Reason, as told by Norton Juster in The Phantom
>  Tollbooth
> 

-- 
Mathieu Desnoyers
Operating System Efficiency R&D Consultant
EfficiOS Inc.
http://www.efficios.com