From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [patch 3/4] mm: filemap: pass __GFP_WRITE from grab_cache_page_write_begin() Date: Tue, 20 Sep 2011 14:40:34 -0400 Message-ID: <20110920184034.GA27353@infradead.org> References: <1316526315-16801-1-git-send-email-jweiner@redhat.com> <1316526315-16801-4-git-send-email-jweiner@redhat.com> <20110920142553.GA2593@infradead.org> <4E78DD8B.1020605@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Christoph Hellwig , Johannes Weiner , Andrew Morton , Mel Gorman , Dave Chinner , Wu Fengguang , Jan Kara , Minchan Kim , Chris Mason , Theodore Ts'o , Andreas Dilger , xfs@oss.sgi.com, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org To: Rik van Riel Return-path: In-Reply-To: <4E78DD8B.1020605@redhat.com> List-ID: On Tue, Sep 20, 2011 at 02:38:03PM -0400, Rik van Riel wrote: > On 09/20/2011 10:25 AM, Christoph Hellwig wrote: > >In addition to regular write shouldn't __do_fault and do_wp_page also > >calls this if they are called on file backed mappings? > > > > Probably not do_wp_page since it always creates an > anonymous page, which are not very relevant to the > dirty page cache accounting. Well, it doesn't always - but for the case where it doesn't we do not allocate a new page at all so you're right in the end :) -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id p8KIewPS076729 for ; Tue, 20 Sep 2011 13:40:59 -0500 Received: from bombadil.infradead.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id F0D011403C62 for ; Tue, 20 Sep 2011 11:46:16 -0700 (PDT) Received: from bombadil.infradead.org (173-166-109-252-newengland.hfc.comcastbusiness.net [173.166.109.252]) by cuda.sgi.com with ESMTP id MsdyJOAUTBXgW30n for ; Tue, 20 Sep 2011 11:46:16 -0700 (PDT) Date: Tue, 20 Sep 2011 14:40:34 -0400 From: Christoph Hellwig Subject: Re: [patch 3/4] mm: filemap: pass __GFP_WRITE from grab_cache_page_write_begin() Message-ID: <20110920184034.GA27353@infradead.org> References: <1316526315-16801-1-git-send-email-jweiner@redhat.com> <1316526315-16801-4-git-send-email-jweiner@redhat.com> <20110920142553.GA2593@infradead.org> <4E78DD8B.1020605@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <4E78DD8B.1020605@redhat.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Rik van Riel Cc: linux-ext4@vger.kernel.org, Jan Kara , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, xfs@oss.sgi.com, Christoph Hellwig , linux-mm@kvack.org, Andreas Dilger , Mel Gorman , linux-fsdevel@vger.kernel.org, Theodore Ts'o , Andrew Morton , Wu Fengguang , Johannes Weiner , Chris Mason , Minchan Kim On Tue, Sep 20, 2011 at 02:38:03PM -0400, Rik van Riel wrote: > On 09/20/2011 10:25 AM, Christoph Hellwig wrote: > >In addition to regular write shouldn't __do_fault and do_wp_page also > >calls this if they are called on file backed mappings? > > > > Probably not do_wp_page since it always creates an > anonymous page, which are not very relevant to the > dirty page cache accounting. Well, it doesn't always - but for the case where it doesn't we do not allocate a new page at all so you're right in the end :) _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752070Ab1ITSk7 (ORCPT ); Tue, 20 Sep 2011 14:40:59 -0400 Received: from 173-166-109-252-newengland.hfc.comcastbusiness.net ([173.166.109.252]:39489 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750928Ab1ITSk6 (ORCPT ); Tue, 20 Sep 2011 14:40:58 -0400 Date: Tue, 20 Sep 2011 14:40:34 -0400 From: Christoph Hellwig To: Rik van Riel Cc: Christoph Hellwig , Johannes Weiner , Andrew Morton , Mel Gorman , Dave Chinner , Wu Fengguang , Jan Kara , Minchan Kim , Chris Mason , "Theodore Ts'o" , Andreas Dilger , xfs@oss.sgi.com, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [patch 3/4] mm: filemap: pass __GFP_WRITE from grab_cache_page_write_begin() Message-ID: <20110920184034.GA27353@infradead.org> References: <1316526315-16801-1-git-send-email-jweiner@redhat.com> <1316526315-16801-4-git-send-email-jweiner@redhat.com> <20110920142553.GA2593@infradead.org> <4E78DD8B.1020605@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4E78DD8B.1020605@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 20, 2011 at 02:38:03PM -0400, Rik van Riel wrote: > On 09/20/2011 10:25 AM, Christoph Hellwig wrote: > >In addition to regular write shouldn't __do_fault and do_wp_page also > >calls this if they are called on file backed mappings? > > > > Probably not do_wp_page since it always creates an > anonymous page, which are not very relevant to the > dirty page cache accounting. Well, it doesn't always - but for the case where it doesn't we do not allocate a new page at all so you're right in the end :)