Re: [PATCH 4/7] perf, x86: Implement IBS interrupt handler

[Robert Richter <robert.richter@amd.com>]

On 14.09.11 12:13:25, Peter Zijlstra wrote:
> On Wed, 2011-09-07 at 18:36 +0200, Robert Richter wrote:
> > +       if (event->attr.sample_type & PERF_SAMPLE_RAW) {
> > +               ibs_data.caps = ibs_caps;
> > +               size = 1;
> > +               offset = 1;
> > +               do {
> > +                   rdmsrl(msr + offset, *buf++);
> > +                   size++;
> > +                   offset = find_next_bit(perf_ibs->offset_mask,
> > +                                          perf_ibs->offset_max,
> > +                                          offset + 1);
> > +               } while (offset < perf_ibs->offset_max);
> > +               raw.size = sizeof(u32) + sizeof(u64) * size;
> > +               raw.data = ibs_data.data;
> > +               data.raw = &raw;
> > +       } 
> 
> Another application of for_each_set_bit_continue() ?

Peter, I will make this a separate patch set to decouple from this
patch set. Will then update this code too. So in my next ibs patch set
I wont change this here.

-Robert

-- 
Advanced Micro Devices, Inc.
Operating System Research Center