All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1 of 2] linux: add linux-update target to save configuration
Date: Wed, 21 Sep 2011 09:28:54 +0200	[thread overview]
Message-ID: <20110921092854.7382e60c@skate> (raw)
In-Reply-To: <9c76ca74224570a6b9e8.1316587575@localhost6.localdomain6>

Hello,

Le Wed, 21 Sep 2011 08:46:15 +0200,
Thomas De Schampheleire <patrickdepinguin+buildroot@gmail.com> a ?crit :

> In analogy to build targets uclibc-update and busybox-update, add linux-update
> that copies the current configuration to the custom configuration file set in
> buildroot.
> This facilitates the work of developers adding support for a specific board
> to buildroot.

Definitely a good thing to have. However:

 * The name if misleading. "linux-update" "busybox-update": one is not
   "updating" Linux or Busybox, but rather copying or updating the
   configuration. So presumably the name of those targets should be
   changed.

 * I don't like the existing behaviour of busybox-update and
   uclibc-update, because they can overwrite the default configuration
   in package/busybox/busybox-xxx.config or
   toolchain/uClibc/uClibc-xxx.config. I think those *-update should
   only take effect if a non-standard configuration file was proposed,
   as you did for the Linux one.

 * For the Linux kernel, I do use savedefconfig, so I'd like to see
   either this "linux-update" thing use savedefconfig, or have a
   separate option that does the same thing as "linux-update" but using
   savedefconfig. Maybe "linux-update-config" and
   "linux-update-minconfig" ?

Regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  reply	other threads:[~2011-09-21  7:28 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-21  6:46 [Buildroot] [PATCH 0 of 2] linux: add linux-update and allow vmlinux for all architectures Thomas De Schampheleire
2011-09-21  6:46 ` [Buildroot] [PATCH 1 of 2] linux: add linux-update target to save configuration Thomas De Schampheleire
2011-09-21  7:28   ` Thomas Petazzoni [this message]
2011-09-21  8:16     ` Thomas De Schampheleire
2011-09-21  6:46 ` [Buildroot] [PATCH 2 of 2] linux: make vmlinux target available to all architectures Thomas De Schampheleire
2011-09-21  7:29   ` Thomas Petazzoni
2011-09-22 19:07     ` Thomas Petazzoni
2011-10-16 10:35       ` Thomas De Schampheleire
2011-10-17  7:15         ` Thomas Petazzoni
2011-10-17  8:38           ` Thomas De Schampheleire
2011-11-14 15:22   ` Peter Korsgaard
  -- strict thread matches above, loose matches on Subject: below --
2011-02-27 14:37 [Buildroot] [PATCH 0 of 2] Facilitate saving of configuration files for board developers Thomas De Schampheleire
2011-02-27 14:37 ` [Buildroot] [PATCH 1 of 2] linux: add linux-update target to save configuration Thomas De Schampheleire

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110921092854.7382e60c@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.