From: Matthew Garrett <mjg@redhat.com>
To: Chen Gong <gong.chen@linux.intel.com>
Cc: tony.luck@intel.com, linux-kernel@vger.kernel.org,
mikew@google.com, saguchi@redhat.com
Subject: Re: [PATCH] efi: Avoid sysfs spew on reboot and panic
Date: Wed, 21 Sep 2011 13:40:18 +0100 [thread overview]
Message-ID: <20110921124018.GA22155@srcf.ucam.org> (raw)
In-Reply-To: <4E795A9C.4040508@linux.intel.com>
On Wed, Sep 21, 2011 at 11:31:40AM +0800, Chen Gong wrote:
> > mutex_lock(&psinfo->buf_mutex);
> > memcpy(psinfo->buf, buf, size);
> >- id = psinfo->write(type, 0, size, psinfo);
> >+ id = psinfo->write(type, 0, KMSG_DUMP_UNKNOWN, size, psinfo);
>
> I can't say it is wrong because no real caller for this function, but I can't
> say it is right, yet. KMSG_DUMP_UNKNOWN here looks too arbirary. Do you have
> any reason to use this type here ?
If a function calls pstore_write() directly then we have no type to
associate with it. It seems worth making this explicit.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2011-09-21 12:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-20 21:07 [PATCH] efi: Avoid sysfs spew on reboot and panic Matthew Garrett
2011-09-21 3:31 ` Chen Gong
2011-09-21 12:40 ` Matthew Garrett [this message]
2011-09-22 2:21 ` Chen Gong
2011-09-22 13:15 ` Matthew Garrett
2011-09-23 6:41 ` Chen Gong
2011-09-23 17:11 ` Luck, Tony
2012-01-12 18:33 ` Seiji Aguchi
2011-09-21 13:01 ` Seiji Aguchi
-- strict thread matches above, loose matches on Subject: below --
2012-03-07 22:49 Seiji Aguchi
[not found] <32727E9A83EE9A42A1F0906295A3A77B2E598C0A91@USINDEVS01.corp.hds.com>
2012-04-13 14:37 ` Seiji Aguchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110921124018.GA22155@srcf.ucam.org \
--to=mjg@redhat.com \
--cc=gong.chen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mikew@google.com \
--cc=saguchi@redhat.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.