From: Seth Forshee <seth.forshee@canonical.com>
To: Joe Perches <joe@perches.com>
Cc: Matthew Garrett <mjg@redhat.com>,
Azael Avalos <coproscefalo@gmail.com>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/6] toshiba_acpi: Convert to use acpi_driver
Date: Wed, 21 Sep 2011 07:52:52 -0500 [thread overview]
Message-ID: <20110921125252.GA23254@thinkpad-t410> (raw)
In-Reply-To: <1316557078.1903.11.camel@Joe-Laptop>
On Tue, Sep 20, 2011 at 03:17:57PM -0700, Joe Perches wrote:
> On Tue, 2011-09-20 at 16:55 -0500, Seth Forshee wrote:
> > Changes toshiba_acpi to register an acpi driver and eliminates the
> > platform device it was using.
>
> Just trivial comments...
Thanks for the suggestions. Since all those are existing code rather
than new code, I'll incorporate them if I have to respin the patches
(aside from the static problems that Corentin pointed out), otherwise
they can be done in a follow-on patch.
next prev parent reply other threads:[~2011-09-21 12:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-20 21:55 [PATCH 0/6] toshiba_acpi: Cleanup and TOS1900 device support Seth Forshee
2011-09-20 21:55 ` [PATCH 1/6] toshiba_acpi: Convert to use acpi_driver Seth Forshee
2011-09-20 22:17 ` Joe Perches
2011-09-21 7:31 ` Corentin Chary
2011-09-21 12:52 ` Seth Forshee [this message]
2011-09-21 7:28 ` Corentin Chary
2011-09-21 13:24 ` Seth Forshee
2011-09-21 13:30 ` Corentin Chary
2011-09-21 15:13 ` Azael Avalos
2011-09-21 15:35 ` Matthew Garrett
2011-09-20 21:55 ` [PATCH 2/6] toshiba_acpi: Fix up return codes Seth Forshee
2011-09-20 21:55 ` [PATCH 3/6] toshiba_acpi: Use handle for HCI calls Seth Forshee
2011-09-20 21:55 ` [PATCH 4/6] toshiba_acpi: Support SPFC as an HCI method Seth Forshee
2011-09-20 21:55 ` [PATCH 5/6] toshiba_acpi: Don't add devices for unsupported features Seth Forshee
2011-09-20 21:55 ` [PATCH 6/6] toshiba_acpi: Initialize brightness in backlight device Seth Forshee
2011-09-21 15:31 ` [PATCH 0/6] toshiba_acpi: Cleanup and TOS1900 device support Matthew Garrett
2011-09-21 16:10 ` Seth Forshee
2011-10-26 13:54 ` Seth Forshee
2011-10-26 16:58 ` Azael Avalos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110921125252.GA23254@thinkpad-t410 \
--to=seth.forshee@canonical.com \
--cc=coproscefalo@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.