From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johannes Weiner Subject: Re: [patch 3/4] mm: filemap: pass __GFP_WRITE from grab_cache_page_write_begin() Date: Wed, 21 Sep 2011 16:09:35 +0200 Message-ID: <20110921140935.GF22516@redhat.com> References: <1316526315-16801-1-git-send-email-jweiner@redhat.com> <1316526315-16801-4-git-send-email-jweiner@redhat.com> <20110920142553.GA2593@infradead.org> <4E78DD8B.1020605@redhat.com> <20110920184034.GA27353@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Rik van Riel , Andrew Morton , Mel Gorman , Dave Chinner , Wu Fengguang , Jan Kara , Minchan Kim , Chris Mason , "Theodore Ts'o" , Andreas Dilger , xfs@oss.sgi.com, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org To: Christoph Hellwig Return-path: In-Reply-To: <20110920184034.GA27353@infradead.org> List-ID: On Tue, Sep 20, 2011 at 02:40:34PM -0400, Christoph Hellwig wrote: > On Tue, Sep 20, 2011 at 02:38:03PM -0400, Rik van Riel wrote: > > On 09/20/2011 10:25 AM, Christoph Hellwig wrote: > > >In addition to regular write shouldn't __do_fault and do_wp_page also > > >calls this if they are called on file backed mappings? > > > > Probably not do_wp_page since it always creates an > > anonymous page, which are not very relevant to the > > dirty page cache accounting. > > Well, it doesn't always - but for the case where it doesn't we > do not allocate a new page at all so you're right in the end :) I think it could be useful to annotate write-fault allocations in filemap_fault(), but these pages are mostly allocated in the readahead code, so this could turn into a more invasive project. It can be done incrementally, however, the series as it stands does not require it to be useful. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id p8LE9tHF147802 for ; Wed, 21 Sep 2011 09:09:55 -0500 Received: from mx1.redhat.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 6031C17E761 for ; Wed, 21 Sep 2011 07:09:54 -0700 (PDT) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by cuda.sgi.com with ESMTP id lLVEoT5OwVIFpQ87 for ; Wed, 21 Sep 2011 07:09:54 -0700 (PDT) Date: Wed, 21 Sep 2011 16:09:35 +0200 From: Johannes Weiner Subject: Re: [patch 3/4] mm: filemap: pass __GFP_WRITE from grab_cache_page_write_begin() Message-ID: <20110921140935.GF22516@redhat.com> References: <1316526315-16801-1-git-send-email-jweiner@redhat.com> <1316526315-16801-4-git-send-email-jweiner@redhat.com> <20110920142553.GA2593@infradead.org> <4E78DD8B.1020605@redhat.com> <20110920184034.GA27353@infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20110920184034.GA27353@infradead.org> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Christoph Hellwig Cc: Rik van Riel , linux-ext4@vger.kernel.org, Jan Kara , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, xfs@oss.sgi.com, linux-mm@kvack.org, Andreas Dilger , Mel Gorman , linux-fsdevel@vger.kernel.org, Theodore Ts'o , Andrew Morton , Wu Fengguang , Chris Mason , Minchan Kim On Tue, Sep 20, 2011 at 02:40:34PM -0400, Christoph Hellwig wrote: > On Tue, Sep 20, 2011 at 02:38:03PM -0400, Rik van Riel wrote: > > On 09/20/2011 10:25 AM, Christoph Hellwig wrote: > > >In addition to regular write shouldn't __do_fault and do_wp_page also > > >calls this if they are called on file backed mappings? > > > > Probably not do_wp_page since it always creates an > > anonymous page, which are not very relevant to the > > dirty page cache accounting. > > Well, it doesn't always - but for the case where it doesn't we > do not allocate a new page at all so you're right in the end :) I think it could be useful to annotate write-fault allocations in filemap_fault(), but these pages are mostly allocated in the readahead code, so this could turn into a more invasive project. It can be done incrementally, however, the series as it stands does not require it to be useful. _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751304Ab1IUOKW (ORCPT ); Wed, 21 Sep 2011 10:10:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59745 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751049Ab1IUOKT (ORCPT ); Wed, 21 Sep 2011 10:10:19 -0400 Date: Wed, 21 Sep 2011 16:09:35 +0200 From: Johannes Weiner To: Christoph Hellwig Cc: Rik van Riel , Andrew Morton , Mel Gorman , Dave Chinner , Wu Fengguang , Jan Kara , Minchan Kim , Chris Mason , "Theodore Ts'o" , Andreas Dilger , xfs@oss.sgi.com, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [patch 3/4] mm: filemap: pass __GFP_WRITE from grab_cache_page_write_begin() Message-ID: <20110921140935.GF22516@redhat.com> References: <1316526315-16801-1-git-send-email-jweiner@redhat.com> <1316526315-16801-4-git-send-email-jweiner@redhat.com> <20110920142553.GA2593@infradead.org> <4E78DD8B.1020605@redhat.com> <20110920184034.GA27353@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110920184034.GA27353@infradead.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 20, 2011 at 02:40:34PM -0400, Christoph Hellwig wrote: > On Tue, Sep 20, 2011 at 02:38:03PM -0400, Rik van Riel wrote: > > On 09/20/2011 10:25 AM, Christoph Hellwig wrote: > > >In addition to regular write shouldn't __do_fault and do_wp_page also > > >calls this if they are called on file backed mappings? > > > > Probably not do_wp_page since it always creates an > > anonymous page, which are not very relevant to the > > dirty page cache accounting. > > Well, it doesn't always - but for the case where it doesn't we > do not allocate a new page at all so you're right in the end :) I think it could be useful to annotate write-fault allocations in filemap_fault(), but these pages are mostly allocated in the readahead code, so this could turn into a more invasive project. It can be done incrementally, however, the series as it stands does not require it to be useful.