All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: Kautuk Consul <consul.kautuk@gmail.com>
Cc: Jiri Kosina <trivial@kernel.org>,
	jkosina@suse.cz, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] Trivial: devtmpfsd: Setting task running/interruptible states
Date: Wed, 21 Sep 2011 08:54:44 -0700	[thread overview]
Message-ID: <20110921155444.GA27121@suse.de> (raw)
In-Reply-To: <1316619573-9104-1-git-send-email-consul.kautuk@gmail.com>

On Wed, Sep 21, 2011 at 09:09:33PM +0530, Kautuk Consul wrote:
> This trivial patch makes the following changes in devtmpfsd() :

This is not the definition of "trivial" in that you are changing the
logic of the code, not just doing spelling changes.

> - Set the state to TASK_INTERRUPTIBLE using __set_current_state
>   instead of set_current_state as the spin_unlock is an implicit
>   memory barrier.

Why?  What is this hurting with the original code?

> - After return from schedule(), there is no need to set the current
>   state to TASK_RUNNING as the wake_up_process() function call will
>   do this for us.

Are you sure?

Have you tested this patch and everything works properly?

greg k-h

  reply	other threads:[~2011-09-21 16:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-21 15:39 [PATCH 1/1] Trivial: devtmpfsd: Setting task running/interruptible states Kautuk Consul
2011-09-21 15:54 ` Greg KH [this message]
2011-09-21 16:24   ` kautuk.c @samsung.com
2011-09-21 21:10     ` Greg KH
2011-09-22  3:25       ` kautuk.c @samsung.com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110921155444.GA27121@suse.de \
    --to=gregkh@suse.de \
    --cc=consul.kautuk@gmail.com \
    --cc=jkosina@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.