From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Arnd Bergmann <arnd@arndb.de>
Cc: H Hartley Sweeten <hartleys@visionengravers.com>,
Linux Kernel <linux-kernel@vger.kernel.org>,
linux-pm@lists.linux-foundation.org, akpm@linux-foundation.org,
gregkh@suse.de, pavel@ucw.cz, len.brown@intel.com, art@ified.ca,
jslaby@suse.cz
Subject: Re: [PATCH] vt/suspend: cleanup #if defined uglyness and fix compile error
Date: Wed, 21 Sep 2011 22:59:30 +0200 [thread overview]
Message-ID: <201109212259.30843.rjw@sisk.pl> (raw)
In-Reply-To: <201109071849.43603.arnd@arndb.de>
On Wednesday, September 07, 2011, Arnd Bergmann wrote:
> On Tuesday 06 September 2011, H Hartley Sweeten wrote:
> > rder to cleanup
> > the #if defined ugliness for the vt suspend support functions. Note that
> > CONFIG_VT_CONSOLE is already dependant on CONFIG_VT.
> >
> > The function pm_set_vt_switch is actually dependant on CONFIG_VT and not
> > CONFIG_PM_SLEEP. This fixes a compile error when CONFIG_PM_SLEEP is
> > not set:
> >
> > drivers/tty/vt/vt_ioctl.c:1794: error: redefinition of 'pm_set_vt_switch'
> > include/linux/suspend.h:17: error: previous definition of 'pm_set_vt_switch' was here
> >
> > Also, remove the incorrect path from the comment in console.c.
> >
> > Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> > Cc: Arnd Bergmann <arnd@arnd.de>
> > Cc: Andrew Morton <akpm@linux-foundation.org>
> > Cc: Greg Kroah-Hartman <gregkh@suse.de>
> > Cc: Pavel Machek <pavel@ucw.cz>
> > Cc: "Rafael J. Wysocki" <rjw@sisk.pl>
> > Cc: Len Brown <len.brown@intel.com>
> > Cc: Arthur Taylor <art@ified.ca>
> > Cc: Jiri Slaby <jslaby@suse.cz>
>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
Applied to linux-pm/linux-next, will be pushed for 3.2.
Thanks (and sorry for the delay),
Rafael
next prev parent reply other threads:[~2011-09-21 20:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-06 21:04 [PATCH] vt/suspend: cleanup #if defined uglyness and fix compile error H Hartley Sweeten
2011-09-07 16:49 ` Arnd Bergmann
2011-09-21 20:59 ` Rafael J. Wysocki [this message]
2011-09-07 16:49 ` Arnd Bergmann
-- strict thread matches above, loose matches on Subject: below --
2011-09-06 21:04 H Hartley Sweeten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201109212259.30843.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=art@ified.ca \
--cc=gregkh@suse.de \
--cc=hartleys@visionengravers.com \
--cc=jslaby@suse.cz \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.