From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752644Ab1IVJ6H (ORCPT ); Thu, 22 Sep 2011 05:58:07 -0400 Received: from shutemov.name ([188.40.19.243]:55269 "EHLO shutemov.name" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752484Ab1IVJ6F (ORCPT ); Thu, 22 Sep 2011 05:58:05 -0400 Date: Thu, 22 Sep 2011 12:58:03 +0300 From: "Kirill A. Shutemov" To: Greg Thelen Cc: Glauber Costa , linux-kernel@vger.kernel.org, paul@paulmenage.org, lizf@cn.fujitsu.com, kamezawa.hiroyu@jp.fujitsu.com, ebiederm@xmission.com, davem@davemloft.net, netdev@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v3 6/7] tcp buffer limitation: per-cgroup limit Message-ID: <20110922095803.GA4530@shutemov.name> References: <1316393805-3005-1-git-send-email-glommer@parallels.com> <1316393805-3005-7-git-send-email-glommer@parallels.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 21, 2011 at 11:01:46PM -0700, Greg Thelen wrote: > On Sun, Sep 18, 2011 at 5:56 PM, Glauber Costa wrote: > > +static inline bool mem_cgroup_is_root(struct mem_cgroup *mem) > > +{ > > +       return (mem == root_mem_cgroup); > > +} > > + > > Why are you adding a copy of mem_cgroup_is_root(). I see one already > in v3.0. Was it deleted in a previous patch? mem_cgroup_is_root() moved up in the file. -- Kirill A. Shutemov From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail6.bemta8.messagelabs.com (mail6.bemta8.messagelabs.com [216.82.243.55]) by kanga.kvack.org (Postfix) with ESMTP id D21AD9000BD for ; Thu, 22 Sep 2011 05:58:05 -0400 (EDT) Date: Thu, 22 Sep 2011 12:58:03 +0300 From: "Kirill A. Shutemov" Subject: Re: [PATCH v3 6/7] tcp buffer limitation: per-cgroup limit Message-ID: <20110922095803.GA4530@shutemov.name> References: <1316393805-3005-1-git-send-email-glommer@parallels.com> <1316393805-3005-7-git-send-email-glommer@parallels.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: owner-linux-mm@kvack.org List-ID: To: Greg Thelen Cc: Glauber Costa , linux-kernel@vger.kernel.org, paul@paulmenage.org, lizf@cn.fujitsu.com, kamezawa.hiroyu@jp.fujitsu.com, ebiederm@xmission.com, davem@davemloft.net, netdev@vger.kernel.org, linux-mm@kvack.org On Wed, Sep 21, 2011 at 11:01:46PM -0700, Greg Thelen wrote: > On Sun, Sep 18, 2011 at 5:56 PM, Glauber Costa wrote: > > +static inline bool mem_cgroup_is_root(struct mem_cgroup *mem) > > +{ > > + return (mem == root_mem_cgroup); > > +} > > + > > Why are you adding a copy of mem_cgroup_is_root(). I see one already > in v3.0. Was it deleted in a previous patch? mem_cgroup_is_root() moved up in the file. -- Kirill A. Shutemov -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Kirill A. Shutemov" Subject: Re: [PATCH v3 6/7] tcp buffer limitation: per-cgroup limit Date: Thu, 22 Sep 2011 12:58:03 +0300 Message-ID: <20110922095803.GA4530@shutemov.name> References: <1316393805-3005-1-git-send-email-glommer@parallels.com> <1316393805-3005-7-git-send-email-glommer@parallels.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Cc: Glauber Costa , linux-kernel@vger.kernel.org, paul@paulmenage.org, lizf@cn.fujitsu.com, kamezawa.hiroyu@jp.fujitsu.com, ebiederm@xmission.com, davem@davemloft.net, netdev@vger.kernel.org, linux-mm@kvack.org To: Greg Thelen Return-path: Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org List-Id: netdev.vger.kernel.org On Wed, Sep 21, 2011 at 11:01:46PM -0700, Greg Thelen wrote: > On Sun, Sep 18, 2011 at 5:56 PM, Glauber Costa = wrote: > > +static inline bool mem_cgroup_is_root(struct mem_cgroup *mem) > > +{ > > + =A0 =A0 =A0 return (mem =3D=3D root_mem_cgroup); > > +} > > + >=20 > Why are you adding a copy of mem_cgroup_is_root(). I see one already > in v3.0. Was it deleted in a previous patch? mem_cgroup_is_root() moved up in the file. --=20 Kirill A. Shutemov -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter= .ca/ Don't email: email@kvack.org