From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] GCC4.6: Convert various empty macros to inline functions
Date: Fri, 23 Sep 2011 16:33:46 -0400 [thread overview]
Message-ID: <201109231633.47565.vapier@gentoo.org> (raw)
In-Reply-To: <1316804993-29406-1-git-send-email-marek.vasut@gmail.com>
On Friday, September 23, 2011 15:09:52 Marek Vasut wrote:
> --- a/include/common.h
> +++ b/include/common.h
>
> -#define debugX(level,fmt,args...)
> +static inline void debugX(const char *fmt, ...) {}
NAK: you broke debugX()
personally i'd prefer we unify these like we did with the assert(), but this
change is better than nothing
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20110923/ce8ec9bd/attachment.pgp
next prev parent reply other threads:[~2011-09-23 20:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-23 19:09 [U-Boot] [PATCH 1/2] GCC4.6: Convert various empty macros to inline functions Marek Vasut
2011-09-23 19:09 ` [U-Boot] [PATCH 2/2] GCC4.6: Remove unused "port" variable in cmd_usb.c Marek Vasut
2011-09-24 17:37 ` Remy Bohmer
2011-09-23 20:33 ` Mike Frysinger [this message]
2011-09-23 21:52 ` [U-Boot] [PATCH 1/2] GCC4.6: Convert various empty macros to inline functions Marek Vasut
2011-09-23 23:04 ` Mike Frysinger
2011-09-24 0:40 ` Marek Vasut
2011-09-24 5:05 ` Mike Frysinger
2011-09-23 22:22 ` [U-Boot] [PATCH] " Marek Vasut
2011-09-23 22:22 ` [U-Boot] [PATCH 1/2 V2] " Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201109231633.47565.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.