All of lore.kernel.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: DT vs ARM static mappings
Date: Fri, 23 Sep 2011 17:45:06 +0200	[thread overview]
Message-ID: <201109231745.06264.arnd@arndb.de> (raw)
In-Reply-To: <1316708611.4611.873.camel@hornet.cambridge.arm.com>

On Thursday 22 September 2011, Pawel Moll wrote:
> Executive summary:
> 
> * I have second map_desc with pfn for RS1 memory map, but using the same
> virtual address as the legacy one. The legacy one is used if root of the
> tree is compatible with "arm,vexpress-legacy".
> 
> * The devices I need to use in v2m.c have aliases in DTS so I can find
> their offsets in the flat tree (the *_find_node_by_alias() function is
> rather generic and could be moved to drivers/of/fdt.c if you think it
> would be useful for others).
> 
> * There are no more users of MMIO_P2V in v2m.c, next thing I will do is
> the same in core tile; then the macro can be killed. Once this happens
> the virtual address currently taken from __MMIO_P2V(V2M_PA_CS7) will be
> replaced by some kind of "#define V2M_PERIPH_BASE 0xf8000000".
> 
> * Once Nico's changes regarding static maps are in, the manual pointer
> operations in v2m_dt_map_io can be replaced with neat ioremap()-s.
> 
> All feedback appreciated, cheers!

Look ok to me. Just a comment on the submission:

Even when you post something for review instead of inclusion, please add
a Signed-off-by: line and a diffstat.

	Arnd

WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
To: Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: DT vs ARM static mappings
Date: Fri, 23 Sep 2011 17:45:06 +0200	[thread overview]
Message-ID: <201109231745.06264.arnd@arndb.de> (raw)
In-Reply-To: <1316708611.4611.873.camel-okZbbLrgpR/YkXV2EHHjLW3o5bpOHsLO@public.gmane.org>

On Thursday 22 September 2011, Pawel Moll wrote:
> Executive summary:
> 
> * I have second map_desc with pfn for RS1 memory map, but using the same
> virtual address as the legacy one. The legacy one is used if root of the
> tree is compatible with "arm,vexpress-legacy".
> 
> * The devices I need to use in v2m.c have aliases in DTS so I can find
> their offsets in the flat tree (the *_find_node_by_alias() function is
> rather generic and could be moved to drivers/of/fdt.c if you think it
> would be useful for others).
> 
> * There are no more users of MMIO_P2V in v2m.c, next thing I will do is
> the same in core tile; then the macro can be killed. Once this happens
> the virtual address currently taken from __MMIO_P2V(V2M_PA_CS7) will be
> replaced by some kind of "#define V2M_PERIPH_BASE 0xf8000000".
> 
> * Once Nico's changes regarding static maps are in, the manual pointer
> operations in v2m_dt_map_io can be replaced with neat ioremap()-s.
> 
> All feedback appreciated, cheers!

Look ok to me. Just a comment on the submission:

Even when you post something for review instead of inclusion, please add
a Signed-off-by: line and a diffstat.

	Arnd

  reply	other threads:[~2011-09-23 15:45 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-20 11:51 DT vs ARM static mappings Pawel Moll
2011-09-20 11:51 ` Pawel Moll
2011-09-20 12:58 ` Rob Herring
2011-09-20 12:58   ` Rob Herring
2011-09-20 14:02   ` Pawel Moll
2011-09-20 14:02     ` Pawel Moll
2011-09-20 14:37     ` Rob Herring
2011-09-20 14:37       ` Rob Herring
2011-09-20 16:16       ` Pawel Moll
2011-09-20 16:16         ` Pawel Moll
2011-09-20 19:28         ` Arnd Bergmann
2011-09-20 19:28           ` Arnd Bergmann
2011-09-21  9:41           ` Pawel Moll
2011-09-21  9:41             ` Pawel Moll
2011-09-21  9:59             ` Dave Martin
2011-09-21  9:59               ` Dave Martin
2011-09-21 10:02               ` Pawel Moll
2011-09-21 10:02                 ` Pawel Moll
2011-09-22 16:23           ` Pawel Moll
2011-09-22 16:23             ` Pawel Moll
2011-09-23 15:45             ` Arnd Bergmann [this message]
2011-09-23 15:45               ` Arnd Bergmann
2011-09-21 17:49 ` Nicolas Pitre
2011-09-21 17:49   ` Nicolas Pitre
2011-09-22 13:04   ` Pawel Moll
2011-09-22 13:04     ` Pawel Moll
2011-09-22 13:13     ` Russell King - ARM Linux
2011-09-22 13:13       ` Russell King - ARM Linux
2011-09-22 13:45       ` Pawel Moll
2011-09-22 13:45         ` Pawel Moll
     [not found]         ` <1316699153.4611.858.camel-okZbbLrgpR/YkXV2EHHjLW3o5bpOHsLO@public.gmane.org>
2011-09-22 13:59           ` Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201109231745.06264.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.