From: Arnaldo Carvalho de Melo <acme@infradead.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, Anton Blanchard <anton@samba.org>,
Darren Hart <dvhart@linux.intel.com>,
David Ahern <dsahern@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Eric B Munson <emunson@mgebm.net>,
Frederic Weisbecker <fweisbec@gmail.com>,
Ian Munsie <imunsie@au1.ibm.com>, Ingo Molnar <mingo@elte.hu>,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
Mike Galbraith <efault@gmx.de>, Paul Mackerras <paulus@samba.org>,
Pekka Enberg <penberg@cs.helsinki.fi>,
Peter Zijlstra <peterz@infradead.org>,
Robert Richter <robert.richter@amd.com>,
Stephane Eranian <eranian@google.com>,
Thomas Gleixner <tglx@linutronix.de>,
yrl.pp-manager.tt@hitachi.com
Subject: Re: [GIT PULL 00/12] perf tools fixes
Date: Fri, 23 Sep 2011 18:25:23 -0300 [thread overview]
Message-ID: <20110923212523.GD27519@ghostprotocols.net> (raw)
In-Reply-To: <20110923211158.GC27519@ghostprotocols.net>
Em Fri, Sep 23, 2011 at 06:11:58PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Fri, Sep 23, 2011 at 02:05:25PM -0700, Linus Torvalds escreveu:
> > On Fri, Sep 23, 2011 at 2:03 PM, Linus Torvalds
> > <torvalds@linux-foundation.org> wrote:
> > >
> > > But it obviously doesn't affect the kernel compile. It *does* affect
> > > the perf tool compile, and util/python.c no longer compiles because
> > > the byte-swap flag isn't passed to it.
> >
> > This stupid patch makes it compile. But see the comment..
>
> Yes, this is what I was going to push and will if you haven't already
> done so, did you?
Well, its in that branch now.
It should be 0 or false for that last parm (swapped) because in the
python binding we're not processing perf.data files that may have been
captured on another machine of a different endianness, but an events
stream in the same machine.
Sorry about the noise, there is a problem in the way the python binding
is built, i.e. it should notice that the header changed and rebuild the
python binding, I bet this was what made David not notice it :-\
You noticed it probably because it was the first build of the tool on
your local repo or used a new O= output dir.
- Arnaldo
next prev parent reply other threads:[~2011-09-23 21:25 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-23 20:26 [GIT PULL 00/12] perf tools fixes Arnaldo Carvalho de Melo
2011-09-23 20:26 ` [PATCH 01/12] perf probe: Fix regression of variable finder Arnaldo Carvalho de Melo
2011-09-23 20:26 ` [PATCH 02/12] perf symbols: Fix ppc64 SEGV in dso__load_sym with debuginfo files Arnaldo Carvalho de Melo
2011-09-23 20:26 ` [PATCH 03/12] perf symbols: /proc/kallsyms does not sort module symbols Arnaldo Carvalho de Melo
2011-09-23 20:26 ` [PATCH 04/12] perf symbols: Preserve symbol scope when parsing /proc/kallsyms Arnaldo Carvalho de Melo
2011-09-23 20:26 ` [PATCH 05/12] perf symbols: Add some heuristics for choosing the best duplicate symbol Arnaldo Carvalho de Melo
2011-09-23 20:26 ` [PATCH 06/12] perf record: Create events initially disabled and enable after init Arnaldo Carvalho de Melo
2011-09-23 20:26 ` [PATCH 07/12] perf symbols: Synthesize anonymous mmap events Arnaldo Carvalho de Melo
2011-09-23 20:26 ` [PATCH 08/12] perf sort: Fix symbol sort output by separating unresolved samples by type Arnaldo Carvalho de Melo
2011-09-23 20:26 ` [PATCH 09/12] perf tool: Fix endianness handling of u32 data in samples Arnaldo Carvalho de Melo
2011-09-23 20:26 ` [PATCH 10/12] perf symbols: Fix issue with binaries using 16-bytes buildids (v2) Arnaldo Carvalho de Melo
2011-09-23 20:26 ` [PATCH 11/12] perf top: Fix userspace sample addr map offset Arnaldo Carvalho de Melo
2011-09-23 20:26 ` [PATCH 12/12] perf tools: Add support for disabling -Werror via WERROR=0 Arnaldo Carvalho de Melo
2011-09-23 21:03 ` [GIT PULL 00/12] perf tools fixes Linus Torvalds
2011-09-23 21:05 ` Arnaldo Carvalho de Melo
2011-09-23 21:05 ` Linus Torvalds
2011-09-23 21:11 ` Arnaldo Carvalho de Melo
2011-09-23 21:25 ` Arnaldo Carvalho de Melo [this message]
2011-09-23 23:12 ` Linus Torvalds
2011-09-23 23:31 ` Arnaldo Carvalho de Melo
2011-09-23 23:46 ` Arnaldo Carvalho de Melo
2011-09-24 3:46 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110923212523.GD27519@ghostprotocols.net \
--to=acme@infradead.org \
--cc=anton@samba.org \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=dvhart@linux.intel.com \
--cc=efault@gmx.de \
--cc=emunson@mgebm.net \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=imunsie@au1.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=penberg@cs.helsinki.fi \
--cc=peterz@infradead.org \
--cc=robert.richter@amd.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=yrl.pp-manager.tt@hitachi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.