All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <w.sang@pengutronix.de>
To: rtc-linux@googlegroups.com
Cc: Austin Boyle <Austin.Boyle@Aviatnet.com>,
	Alessandro Zummo <a.zummo@towertech.it>,
	Joakim Tjernlund <Joakim.Tjernlund@transmode.se>,
	linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [rtc-linux] Re: [PATCH 2.6.39-rc7] RTC: rtc-ds1307 EEPROM support for ds1388 chip
Date: Sat, 24 Sep 2011 08:53:32 +0200	[thread overview]
Message-ID: <20110924065332.GA19721@pengutronix.de> (raw)
In-Reply-To: <20110923160445.68c3098e.akpm@google.com>

[-- Attachment #1: Type: text/plain, Size: 1082 bytes --]

On Fri, Sep 23, 2011 at 04:04:45PM -0700, Andrew Morton wrote:
> On Mon, 1 Aug 2011 10:30:57 +1200
> Austin Boyle <Austin.Boyle@Aviatnet.com> wrote:
> 
> > [PATCH 3.0] RTC: EEPROM support for DS1388
> > 
> > This patch adds support for different sized NVRAM, such as
> > the 512 bytes of EEPROM on the DS1388 chip.
> 
> This patch is causing problems in today's linux-next, with x86_64 allmodconfig:

Sorry, I missed the patch so far. The whole approach is not correct.

The EEPROM uses a different I2C slave address (0x69+0x6a) than the RTC (0x68).
So, you should be able to use the ds1307-driver on address 0x68 (maybe with
minor modifications, didn't check that) and the eeprom part using the
at24-driver on address 0x69, selecting the 24c02-type. Despite saving redundant
code, at24 handles peculiarities of EEPROMs much better. Can you please report
if that works for you?

Regards,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

  reply	other threads:[~2011-09-24  6:53 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-23  5:18 [PATCH 2.6.39-rc7] RTC: rtc-ds1307 EEPROM support for ds1388 chip Austin Boyle
2011-06-14  4:14 ` Austin Boyle
2011-07-17 23:32   ` Austin Boyle
2011-07-22 10:19     ` Joakim Tjernlund
2011-07-22 21:54   ` Andrew Morton
2011-07-31 22:30     ` Austin Boyle
2011-09-23 23:04       ` Andrew Morton
2011-09-24  6:53         ` Wolfram Sang [this message]
2011-09-25 10:41         ` Austin Boyle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110924065332.GA19721@pengutronix.de \
    --to=w.sang@pengutronix.de \
    --cc=Austin.Boyle@Aviatnet.com \
    --cc=Joakim.Tjernlund@transmode.se \
    --cc=a.zummo@towertech.it \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rtc-linux@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.