From: Ted Ts'o <tytso@mit.edu>
To: Andreas Dilger <adilger@whamcloud.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH 4/4] e2fsck: regression tests for INCOMPAT_MMP feature
Date: Sun, 25 Sep 2011 08:05:05 -0400 [thread overview]
Message-ID: <20110925120505.GA14539@thunk.org> (raw)
In-Reply-To: <A094EB47-CDD0-4A72-8659-841FC9848BFD@whamcloud.com>
On Sun, Sep 25, 2011 at 12:04:14AM -0600, Andreas Dilger wrote:
> FYI, the reason that I ordered the MMP tests in that way is because it
> makes sense to verify that mke2fs can create a filesystem with the MMP
> feature before using a filesystem created by mke2fs with MMP to test if
> e2fsck handles it correctly.
There are other e2fsck tests that use mke2fs, and for better or for
worse I've never worried about test ordering. If mke2fs blows up for
whatever reason, then some f_* tests will fail for reasons that have
nothing to do with e2fsck. Since the test suite doesn't take that
long to run, most of the time people will let the tests run to
completion and the wise developer will notice the string of mke2fs
failures, and decide to tackle that first. (Or it will be obvious the
moment he or she looks like the failed log files.)
- Ted
next prev parent reply other threads:[~2011-09-25 12:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-23 23:38 [PATCH 1/4] misc: quiet minor compiler errors Andreas Dilger
2011-09-23 23:38 ` [PATCH 2/4] tune2fs: kill external journal if device not found Andreas Dilger
2011-09-24 18:49 ` Ted Ts'o
2011-09-26 17:59 ` Ted Ts'o
2011-09-23 23:38 ` [PATCH 3/4] ext2fs: add multi-mount protection (INCOMPAT_MMP) Andreas Dilger
2011-09-24 18:49 ` Ted Ts'o
2011-09-23 23:38 ` [PATCH 4/4] e2fsck: regression tests for INCOMPAT_MMP feature Andreas Dilger
2011-09-23 23:51 ` Andreas Dilger
2011-09-24 18:51 ` Ted Ts'o
2011-09-25 6:04 ` Andreas Dilger
2011-09-25 12:05 ` Ted Ts'o [this message]
2011-09-23 23:44 ` [PATCH 1/4] misc: quiet minor compiler errors Andreas Dilger
2011-09-24 18:49 ` Ted Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110925120505.GA14539@thunk.org \
--to=tytso@mit.edu \
--cc=adilger@whamcloud.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.